JavaScript Error - Object Expected 1

[craigward]

Hi,

I found some script on the net that will update a text field with the values from selected checkboxes. It stores the value between pages and wil remove items if the users unchecks a box.

I am very poor with JavaScript and keep getting an error saying object expected.

Can anyone see an obvious issue with the following code?

Thanks for any help.


JavaScript

Dim myvalue
function mytester(myvalue,myname){
	
	tester='document.getElementById("'+myname+'").checked'
if (eval(tester)){
if (document.mailerlookup.compareitems.value==''){
	document.mailerlookup.compareitems.value=','+myvalue+','
}
else{
	document.mailerlookup.compareitems.value = document.mailerlookup.compareitems.value+myvalue+','
	}
}
else{
	document.mailerlookup.compareitems.value = document.mailerlookup.compareitems.value.replace(','+myvalue+',', '');
	}
}

Checkboxes, displayed through ASP pulling records from the database.

Response.Write("<tr><td bgcolor='" & strBGColour & "'><input type='checkbox' id='checkbox1863' name='checkbox1863' value='" & objRS("uniqueid") & "' onClick='javascript:mytester(this.value,this.name)' /></td><td bgcolor='" & strBGColour & "'>" & objRS("contact") & "</td><td bgcolor='" & strBGColour & "'>" & objRS("rooms_from") & "</td><td bgcolor='" & strBGColour & "'>" & objRS("idstatus") & "</td><td bgcolor='" & strBGColour & "'>" & objRS("price_from") & "</td><td bgcolor='" & strBGColour & "'>" & objRS("price") & "</td></tr>")

Text field

<input type="text" name="compareitems" />

 

[BillyRayPreachersSon]

"Dim myvalue" is VBScript, no JavaScript. "var myvalue" would be the equivalent statement.

Hope this helps,
Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[BillyRayPreachersSon]

P.S. Did you get a line number with the error? If you did, did it point to that line?

Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[craigward]

That helped Thanks

Still getting the error but the lines doesn't refer to any of the code.

I think it is related to this line.

    document.mailerlookup.compareitems.value=','+myvalue+','

if i replace itwith an alert("test") i get the alert.

Does that help?

Thanks

 

[craigward]

I actually tried alert(myvalue) and i get the result i was expecting, it just won't populate the text field, with

document.mailerlookup.compareitems.value=','+myvalue+','

 

[craigward]

Fixed it!! Thanks