Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Register Log in
  • Congratulations IamaSherpa on being selected by the Tek-Tips community for having the most helpful posts in the forums last week. Way to Go!

Is this An bug?

Status
Not open for further replies.
Vallabh

Vallabh

Technical User
Feb 24, 2006
3
US
Hi,

I am kindaa new to javaScripts. I have written the Following java Serer page

<html>
<head>
<style type="text/css">
div
{
position:absolute;
left:440px;
top:350px;
}
</style>
<script type="text/javascript" >
function validate()
{
var id = document.userpass.id.value;
alert (document.userpass.id.value);
alert(id);
if((id == null)) then
{
alert("User id cannto be null");
document.userpass.id.focus;
return false;
}
return true;
}
</script>
</head>

<body >

<form name="userpass" action="validate" method="POST" onSubmit="return validate()" >
<div>USER ID :<input type="text" name="id" ><br>
Password :<input type="password" name="password"><br>
<input type="submit" value="Login" ></div>
</form>

<body>
</html>
The problem is whenver i enter the USER ID . it is displayed in the Alert Window. However it goes inside the IF looop and the form is not submitted. IE it exactly performs the opposite of what it is supposed to do.. please help me out.

 
Sort by date Sort by votes
There are many things wrong with the script:

- "then" is not a JavaScript keyword. This will cause your code to error.

- You should not use "id" as a form field name, as it may cause some confusion over any possible form id.

- Testing for null is incorrect - you should be testing against an empty string.

- "focus" is a method, and should have brackets after it - "focus()"

Try this as a replacement function:

Code: 
function validate() {
	var frm = document.forms['userpass'].elements;
	var userid =  frm['userid'];
	if (userid.value == '') {
		alert('User id cannot be empty');
		userid.focus();
		return (false);
	}
	return (true);
}

Don't forget to change the name of your form field from "id" to "userid".

Dan

[tt]Dan's Page [blue]@[/blue] Code Couch
[/tt]
 
Upvote 0 Downvote
Hi bill,

Thanks a lot for your reply..

But if i am suppose to access the text value in a single step like this .

var userid = document.userpass.userid.value;
if(userid == '')
{
/* do validations and return false;*/
}
return true;

This doesnt work why ? whats wrong with this?
 
Upvote 0 Downvote
[1] Main reason.
>[tt] if((id == null)) then [/tt]
should be
[tt] if((id == null)) [/tt]
Once error encounter, it will surrender control to caller and submit will go ahead.

[2] Minor things: unrelated to the error.
[2.1]
>[tt]document.userpass.id.focus;[/tt]
[tt]document.userpass.id.focus[red]()[/red];[/tt]
[2.2]
[tt]<body>
<!--- etc -->
<[red]/[/red]body>
[/tt]

 
Upvote 0 Downvote
Correction:
Please ignore this statement---not thinking when I was typing.
Once error encounter, it will surrender control to caller and submit will go ahead.

 
Upvote 0 Downvote
Status
Not open for further replies.

Similar threads

Rayj0000
  • Locked
  • Question
How to disable an html button for subsequent website visitors?
Replies
0
Views
485
Rayj0000
Rayj0000
Mike Lewis
  • Locked
  • Question
Anyone here got any experience of Grid.JS (a sortable Javascript grid) 1
Replies
5
Views
1K
Mike Lewis
Mike Lewis
chikwendu
  • Locked
  • Question
How do I display an extra input box for editing an existing data?
Replies
1
Views
150
chikwendu
chikwendu
JScannell
  • Locked
  • Question
Javascript issue on iPhone/iMac platforms
Replies
0
Views
514
JScannell
JScannell
rogerte
  • Locked
  • Question
Code that works on Windows, Android and Iphone
Replies
0
Views
499
rogerte
rogerte

Part and Inventory Search

Sponsor

Back
Top