Is my "End If" positioned correctly?

roaml · Oct 12, 2003

Hello, Can anyone help me with this?

I need to know what I am doing wrong with my code. I have an input form and the form is pulling from two tables, a wo_table and a project_table. I am calling a work order number from a report list and the input form appears. Now the problem, the form opens and displays the data from the wo_table (this is good), but it only displays the “Builder Information” title and no input fields. I know this is because there are no records matching the work order number I pulled from the wo_table. I am sure there is a way to output empty records.

I am in desperate need of help and appreciate your support. My code is listed below.

<%@ LANGUAGE="vbscript" %>
<% set Dataconn = server.CreateObject("ADODB.Connection&quot

Dataconn.Open "Data Source=wa-prodserv;Provider=SQLOLEDB; Initial Catalog=wotable;User ID=wouse;Password=special6"
session("wo_number&quot

= Request.QueryString("RecordID&quot

msql = "SELECT * FROM wo_table where wo_number=" & Request.QueryString("RecordID&quot

Set RS = DataConn.Execute(msql)
%>

<html>
<head>
<title> Work Order Request</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta http-equiv="Pragma" content="no-cache">
<LINK href/project/css/project.css" rel=stylesheet type="text/css">
<SCRIPT LANGUAGE="JavaScript" SRC="/project/CalendarPopup.js"></SCRIPT>
<SCRIPT LANGUAGE="JavaScript">document.write(CalendarPopup_getStyles());</SCRIPT>
<SCRIPT language="JavaScript1.2" src="/project/validation.js"></SCRIPT>
</HEAD>

<BODY aLink=#003366 bgColor=#ffffff
leftMargin=4 valign="center" link=#003366 topMargin=3 vLink=#003366 marginheight="0" marginwidth="0">

<form method="post" action="post_db.asp" name="WOForm" id="WOForm">
<input type="hidden" name="status" value="Build Completed" size="20">
<input type="hidden" name="builder_name" value="<%=RS("builder_name&quot

%>">
<input type="hidden" name="wo_number" value="<%=RS("wo_number&quot

%>">
<div align="center">
<center>

<table cellspacing="0" cellpadding="0" style="border-collapse: collapse" bordercolor="#6699CC" border="2" width="98%">
<tr>
<td valign="top" bgcolor="#E5E5E5">
<table border="0" cellpadding="0" cellspacing="0" bgcolor="#6699CC" style="border-collapse: collapse" bordercolor="#111111" width="100%">
<tr>
<td style="border-style: none; border-width: medium" bgcolor="#3F7DBC" colspan="2" height="20">
Work Request Form: Development</td>
<td style="border-style: none; border-width: medium" bgcolor="#3F7DBC" height="20" align="right"> Request Date: <%=RS("submit_date&quot

%> </td>
</tr>
<tr>
<td style="border-style: none; border-width: medium" align="center">
Work Order Number: <%=RS("wo_number&quot

%> </td>
<td style="border-style: none; border-width: medium" align="center">
Status: <%=RS("status&quot

%> </td>
<td style="border-style: none; border-width: medium" align="center">
Priority: <%=RS("priority&quot

%>
</STRONG></td>
</tr>
</table></td>
</tr>
<tr>
<td style="border-style: none; border-width: medium" valign="top" >
<table border="1" cellpadding="0" cellspacing="0" bordercolor="##003366" style="border-width:0; border-collapse: collapse" width="100%">
<tr>
<td align="center" style="border-style:none; border-width:medium; " bgcolor="#E5E5E5" valign="top>
<table border="0" style="border-collapse: collapse" bordercolor="#111111" width="100%">
<tr>
<td colspan="2" height="1" > </td>
</tr>
<tr>
<td colspan="2" ></td>
</tr>
<tr>
<td colspan="2"><li class="bullettext"><strong> REQUESTER INFORMATION</strong></td>
</tr>
<tr>
<td width="20"> </td>
<td >

<table border="0" style="border-collapse: collapse" bordercolor="#111111" width="100%" >
<tr>
<td width="300" >Name: <%=RS("requester_name&quot

%></td>

<td >Buidl Date: <%=RS("components&quot

%></td>
</tr>
<tr>
<td width="300" >Phone Number: <%=RS("requester_phone&quot

%></td>

<td >Build Type: <%=RS("request_type&quot

%></td>
</tr>
<tr>
<td width="300" >Department: <%=RS("requester_department&quot

%></td>
<td >Completion Date: <%=RS("required_completion_date&quot

%>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td width="20"> </td>
<td ><br>
Build Description:<br>
<%=RS("project_description&quot

%></td>
</tr>
<tr>
<tr>
\<td colspan="2">
<hr color="#6699CC" size="1"></td>
</tr>
<tr>


<tr>
<td colspan="2"><li class="bullettext"><strong> RELEASE INFORMATION </font> </strong></td>
</tr>

<%
mysql = "SELECT * FROM wo_table where wo_number=" & Request.QueryString("RecordID&quot

Set RS = DataConn.Execute(mysql)
IF not RS.EOF then
%>

<tr>
<td width="20"> </td>
<td >

<table border="0" style="border-collapse: collapse" bordercolor="#111111" width="100%" >
<tr>
<td width="249" >Project Date: <%=RS("project_date&quot

%></td>
<td width="330" >Project Lead: <%=RS("project_lead&quot

%></td>
<td >Site: <%=RS("site&quot

%></td>
<td width="160" >Build Date: <%=RS("build_date&quot

%></td>
</tr>
</table>
</td>
</tr>
<tr>
<%End IF%>


<tr>
<td colspan="2">
<hr color="#6699CC" size="1"></td>
</tr>
<tr>
<td colspan="2" > <li class="bullettext"><STRONG> BUILDER INFORMATION</STRONG></td>
</tr>
<%
mysql = "SELECT * FROM project_table where wo_number=" & Request.QueryString("RecordID&quot

Set DS = DataConn.Execute(mysql)
IF not DS.EOF then

mySQL = "Insert into project_table (wo_number,builder_name,build_start_date,build_completion_date,build_comments) Values('"&wo_number&"','"&builder_name&"','"&build_start_date&"','"&build_completion_date&"','"&build_comments&"');"
%>

<td rowspan="2" > </td>
<td >Builder Name: <%=DS("builder_name&quot

%> Start
Date:

<SCRIPT LANGUAGE="JavaScript">
var cal1x = new CalendarPopup("caldiv1&quot

;
</SCRIPT>
<INPUT TYPE="text" NAME="build_start_date" VALUE="<%=DS("build_start_date&quot

%>" SIZE=10 tabindex="1">
<A HREF="#" onClick="cal1x.select(document.forms[0].build_start_date,'anchor1x','MM/dd/yyyy'); return false;"
NAME="anchor1x" ID="anchor1x"><img border="0" src="/tsd/images/icons/icon_cordinate.gif" title="Select Date"></A>
Completed Date:

<SCRIPT LANGUAGE="JavaScript">
var cal2x = new CalendarPopup("caldiv1&quot

;
</SCRIPT>
<INPUT TYPE="text" NAME="build_completion_date" VALUE="<%=DS("build_completion_date&quot

%>" SIZE=10 tabindex="2">
<A HREF="#" onClick="cal2x.select(document.forms[0].build_completion_date,'anchor2x','MM/dd/yyyy'); return false;"
NAME="anchor2x" ID="anchor2x"><img border="0" src="/tsd/images/icons/icon_cordinate.gif"title="Select Date"></A></td>
<tr>
<td valign="top" ><br>Builder Comments:<br>
<textarea rows="3" name="build_comments" cols="100" tabindex="3"><%=DS("build_comments&quot

%></textarea></td>
</tr>
<tr>
<td ></td>
<td ></td>
</tr>
<tr>
<td colspan="2" align="center"> </td>
</tr>
<%End If %>


<td colspan="7" align="center" >
<input name="submit" type="submit" value="Submit">
</td>
</tr>
</table>
</form>
<ID="caldiv1" STYLE="position:absolute;visibility:hidden;background-color:white;layer-background-color:white;">
</center>
</div>
</BODY>
</HTML>

vpekulas · Oct 12, 2003

A: Is this the entire code you are executing ?
B: By "Builder input fields", do you mean the Date, type, phone etc ?

"Taxes are the fees we pay for civilized society" G.W.

Veep · Oct 12, 2003

Like I said in the other thread you posted, looks like your html. Create a test page minus the ASP code and see what it does.
Instead of creating a new thread just add a new comment to the old one to keep it on top. Otherwise things get really cluttered. Thanks.

bernlaw · Oct 12, 2003

If I understand your problem correctly, you page is displaying fine and shows the output BUILDER INFORMATION and then below that shows the Submit button but not the form fields in-between.

If that is in fact the problem, it would indicate that the problem is that you are attempting to get records from the database into the recordset DS and then checking to see if any records were returned with the line:

IF not DS.EOF then

If you do not have any records in the database that will be returned with the SQL statement:

mysql = "SELECT * FROM project_table where wo_number=" & Request.QueryString("RecordID&quot

then the recordset DS will be at the End of File. So if this is the case, then then no lines will be executed between the IF THEN and the END IF statements. This would mean that you Input forms would never be generated.

If you want them to be generated and displayed, even if the recordset is empty, then use variables instead and put the recordset information into the variable if there was a record returned, or an empty string otherwise.


<tr>
<td colspan="2">
<hr color="#6699CC" size="1"></td>
</tr>
<tr>
<td colspan="2" > <li class="bullettext"><STRONG> BUILDER INFORMATION</STRONG></td>
</tr>
<%
'create the variables
dim wo_number, builder_name, build_start_date
dim build_completion_date, build_comments

mysql = "SELECT * FROM project_table where wo_number=" & Request.QueryString("RecordID&quot

Set DS = DataConn.Execute(mysql)

IF not DS.EOF then
'Add empty string to end, in case of Null field
wo_number = DS("wo_number&quot

& ""
builder_name = DS("builder_name&quot

& ""
build_start_date = DS("build_start_date&quot

& ""
build_completion_date = DS("build_completion_date&quot

& ""
build_comments = DS("build_comments&quot

& ""
else
wo_number = ""
builder_name = ""
build_start_date = ""
build_completion_date = ""
build_comments = ""
end if

'Use the variables in your SQL Insert statement, although you don't appear to ever use this???
mySQL = "Insert into project_table (wo_number,builder_name,build_start_date,build_completion_date,build_comments) Values('"&wo_number&"','"&builder_name&"','"&build_start_date&"','"&build_completion_date&"','"&build_comments&"');"

%>

<td rowspan="2" > </td>
<td >Builder Name: <%=builder_name%> Start
Date:

<SCRIPT LANGUAGE="JavaScript">
var cal1x = new CalendarPopup("caldiv1&quot

;
</SCRIPT>
<INPUT TYPE="text" NAME="build_start_date" VALUE="<%=build_start_date%>" SIZE=10 tabindex="1">
<A HREF="#" onClick="cal1x.select(document.forms[0].build_start_date,'anchor1x','MM/dd/yyyy'); return false;"
NAME="anchor1x" ID="anchor1x"><img border="0" src="/tsd/images/icons/icon_cordinate.gif" title="Select Date"></A>
Completed Date:

<SCRIPT LANGUAGE="JavaScript">
var cal2x = new CalendarPopup("caldiv1&quot

;
</SCRIPT>
<INPUT TYPE="text" NAME="build_completion_date" VALUE="<%=build_completion_date%>" SIZE=10 tabindex="2">
<A HREF="#" onClick="cal2x.select(document.forms[0].build_completion_date,'anchor2x','MM/dd/yyyy'); return false;"
NAME="anchor2x" ID="anchor2x"><img border="0" src="/tsd/images/icons/icon_cordinate.gif"title="Select Date"></A></td>
<tr>
<td valign="top" ><br>Builder Comments:<br>
<textarea rows="3" name="build_comments" cols="100" tabindex="3"><%=build_comments%></textarea></td>
</tr>
<tr>
<td ></td>
<td ></td>
</tr>
<tr>
<td colspan="2" align="center"> </td>
</tr>


<tr>
<td colspan="7" align="center" >
<input name="submit" type="submit" value="Submit">
</td>
</tr>
</table>
</form>
<ID="caldiv1" STYLE="position:absolute;visibility:hidden;background-color:white;layer-background-color:white;">
</center>
</div>
</BODY>
</HTML>

Don't forget to set your connection and recordset objects to Nothing when finished, to free up memory.

set DS=nothing

Hope this helps you out.

Bernie

roaml · Oct 12, 2003

Bernlaw, thank you SO much for helping out. You described excactly what I am trying to do and the problem I am having.

I implemented your code and I still get the following error:

Technical Information (for support personnel)

Error Type:
ADODB.Field (0x80020009)
Either BOF or EOF is True, or the current record has been deleted. Requested operation requires a current record.
/projects/wo_form.asp

I am so frustrated that I could cry!!!!

Thanks again.

bernlaw · Oct 15, 2003

Does the error message give you a line number where the error is actually occuring? This error seems to be happening because you are trying to use a field in the recordset when no information was returned to the recordset. If you can tell what line the error is on, then you can check that line of code specifically to see if it is trying to use a field from the DS recordset.

Bernie

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Is my "End If" positioned correctly?

roaml

Technical User

vpekulas

Programmer

Veep

Programmer

bernlaw

Programmer

roaml

Technical User

bernlaw

Programmer

Similar threads

Part and Inventory Search

Sponsor

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Is my &quot;End If&quot; positioned correctly?

roaml

Technical User

vpekulas

Programmer

Veep

Programmer

bernlaw

Programmer

roaml

Technical User

bernlaw

Programmer

Similar threads

Log in

Part and Inventory Search

Sponsor

Is my "End If" positioned correctly?