Is it Numeric? 3

[sanders720]

Can someone please tell me what I am doing wrong here? I simply want to get the first characters of a string until they become non-numeric and apply the quantity variable Q.

Thanks in advance for the help!


Public Sub IsItNumeric(ByVal ConStr As String)
' Example Data is 12XXX or 12
Dim x As Int16
For x = 1 To ConStr.Length
MsgBox(x)
Try
' IsNumeric(ConStr.Substring(1, x))
Q = Convert.ToInt16(ConStr.Substring(1, x))
MsgBox(Q)

Catch ex As Exception
Q = ConStr.Substring(1, x)
MsgBox(Q)

End Try

Next

End Sub

 

[ThatRickGuy]

Public function IsItNumeric(ByVal ConStr As String) as integer
    ' Example Data is 12XXX or 12
    dim returnVal as integer = 0
    Dim x As Int16
    For x = 1 To ConStr.Length
        if not IsNumeric(ConStr.Substring(x, 1)) then
            returnVal = Convert.ToInt16(ConStr.Substring(1, x-1))
            Exit For
        end if
    Next

    return returnVal
End Sub

-Rick

VB.Net Forum forum796 forum855 ASP.NET Forum
I believe in killer coding ninja monkeys.

 

[ThatRickGuy]

anyways, if the digits are always going to be first, a much easier solutions is:

dim q as integer = integer.parse(ConStr)

-Rick

VB.Net Forum forum796 forum855 ASP.NET Forum
I believe in killer coding ninja monkeys.

 

[chmohan]

Try
If IsNumeric(ConStr.Substring(1, x)) Then
Q = Convert.ToInt16(ConStr.Substring(1, x))
MsgBox(Q)
Else
Exit Sub
End If


Catch ex As Exception

Throw(ex.Message)
End Try

 

[chmohan]

Hmm wont
dim q as integer = integer.parse(ConStr)
throw exception if ConStr is not an integer?

 

[sanders720]

IsNumeric vs Not IsNumeric?

This code produces System.OutofRangeException. The input variable is 12XXX, and I am looking for an int16 of 12 to assign to global variable Q.

Public Sub IsItNumeric(ByVal ConStr As String)
' Example Data is 12XXX or 12
Dim x As Int16
For x = 1 To ConStr.Length
If IsNumeric(ConStr.Substring(x, 1)) Then
Q = Convert.ToInt16(ConStr.Substring(1, x - 1))
Exit For
End If
Next

End Sub

 

[JohnYingling]

Anybody notice that the subscript is starting at 1 instead of 0.

Public Sub IsItNumeric(ByVal ConStr As String)
' Example Data is 12XXX or 12
Dim x As Int16
For x = 0 To ConStr.Length - 1

http://www.moldyoldy.com/VBComparedemo

- free online Compare/Diff of snippets

 

[ThatRickGuy]

My bust, I was thinking it opperated like the old Val command.

Back to my previous post, this should work for '12' as well as '12xxx'

    Public Function IsItNumeric(ByVal ConStr As String) As Integer
      ' Example Data is 12XXX or 12
      Dim returnVal As Integer = 0
      Dim i As Int16
      Dim sTemp As String = ""
      For i = 1 To ConStr.Length
        If Not IsNumeric(ConStr.Substring(i, 1)) Then
          sTemp = ConStr.Substring(1, i - 1)
          Exit For
        End If
      Next
      'check if all characters are numeric
      If sTemp = "" Then sTemp = ConStr

      returnVal = Convert.ToInt16(sTemp)
      Return returnVal
    End Function

-Rick

VB.Net Forum forum796 forum855 ASP.NET Forum
I believe in killer coding ninja monkeys.

 

[ThatRickGuy]

LOL, good catch John! I even missed that after retyping it, heh.

-Rick

VB.Net Forum forum796 forum855 ASP.NET Forum
I believe in killer coding ninja monkeys.

 

[chmohan]

True it should start at 0

 

[sanders720]

Why are we using Not IsNumeric instead of simply IsNumeric?

In my original example, I sought to loop thru four times. If 12XXX were the text, the first time would produce a 1 and would be numeric. The seccond would produce a 12 and also would be numeric. The third would produce 12X, and would not be numeric. So, I want to use 12 for variable Q.

Is there only an option for Not IsNumeric? Thanks for the help.

Public Sub IsItNumeric(ByVal ConStr As String)
' Example Data is 12XXX or 12
Dim x As Int16
For x = 0 To ConStr.Length -1
If IsNumeric(ConStr.Substring(1, x)) Then
Q = Convert.ToInt16(ConStr.Substring(1, x - 1))
Exit For
End If
Next

End Sub

 

[JohnYingling]

???? Q = Convert.ToInt16(ConStr.Substring(1, x - 1))
OR
Q = Convert.ToInt16(ConStr.Substring(0, x - 1))

http://www.moldyoldy.com/VBComparedemo

- free online Compare/Diff of snippets

 

[chmohan]

No you would have to do this

Q should be a string and you should keep on appending until you get to the nonnumeric and then you should convert Q to int
example

Q =Q + ConStr.Substring(1, x - 1)


and when you exit for do this
Dim TotalQ As Integer = Convert.ToInt16(Q)

 

[sanders720]

Yes, but X cannot equal 0

If the string equals 12XXX then 0 would start before the 1 in 12XXX when I assign variable Q. Do I need to use Option Base 1.

Secondly, should IsNumeric work on a string value, like

IsNumeric "12" = True
IsNumeric "12X" = False?

Thanks for your reply


' Example Data is 12XXX or 12
Dim x As Int16
For x = 1 To ConStr.Length
If IsNumeric(ConStr.Substring(1, x)) Then
Q = Convert.ToInt16(ConStr.Substring(1, x))
Else
Q = Convert.ToInt16(ConStr.Substring(1, x - 1))
Exit For
End If
Next
MsgBox(Q)

 

[JohnYingling]

By the way, the strings, "1." and "1,,", both pass the IsNumeric test.

http://www.moldyoldy.com/VBComparedemo

- free online Compare/Diff of snippets

 

[gmmastros]

Also... "12e4" passes the IsNumeric test.

(Hint: Think scientific notation)

-George

Strong and bitter words indicate a weak cause. - Fortune cookie wisdom

 

[JohnYingling]

Stop thinking VB6. Get with the .Net Framework.

Do some step thru debugging.
Dim s as string = ("12").Substring(0,1)

What do you get?

http://www.moldyoldy.com/VBComparedemo

- free online Compare/Diff of snippets

 

[chmohan]

aha nice catch
so we have to do this
Dim sIntegerString as String="1234567890"
and the see if your character lies in this string
if it does then numeric else exit for

 

[JohnYingling]

Also... "12e4" passes the IsNumeric test. "

But "12e" does not pass so it will never get to the 4.

http://www.moldyoldy.com/VBComparedemo

- free online Compare/Diff of snippets

 

[chmohan]

something like this
using the Instr function

http://www.freevbcode.com/ShowCode.asp?ID=4904