insert & update

[Dreamboy2k3]

Can anyone tell me why this won't work please!

I have an insert command that goes like this:

$sql="INSERT INTO news(Title, Body,) VALUES ( \"$title\", \"$body\" )";

Therefore I thought that the update command would be like this:

$sql="UPDATE news SET Title = $title WHERE News_ID = 1"

but it doesn't seem to work?

Could someone show me where I'm going wrong please!! Thanks!

 

[danielhozac]

It would be
[tt]$sql="UPDATE news SET Title = '$title' WHERE News_ID = 1";[/tt]
You need to surround all strings with quotes in SQL.

//Daniel

 

[ThomasJSmart]

i also surround all field names with ` thats the key that also has a ~ on it, i noticed phpMyAdmin does this so i copied...

I learned a bit yesterday, today i learned a lot, imagine what i'll learn tomorrow!

 

[danielhozac]

... which is only needed when you use a reserved word (such as use) for column/table names.

//Daniel

 

[sleipnir214]

... which is a bad idea in any circumstance.

Want the best answers? Ask the best questions:

http://www.catb.org/~esr/faqs/smart-questions.html

TANSTAAFL!

 

[ThomasJSmart]

so why does the very much used phpMyAdmin do this?

I learned a bit yesterday, today i learned a lot, imagine what i'll learn tomorrow!

 

[sleipnir214]

Because it is easier to program a subroutine to put backticks around all column names than it is to figure out which column names are keywords and only put backticks around them.

Want the best answers? Ask the best questions:

http://www.catb.org/~esr/faqs/smart-questions.html

TANSTAAFL!

 

[ThomasJSmart]

ah ok that makes sense

I learned a bit yesterday, today i learned a lot, imagine what i'll learn tomorrow!