Inform me on my new ebay tool

[davejam]

we've just written a new ebay tool for mynza, one of our clients, to create html text for ebay sellers.

its fairly simple but before i deliver it i'm wondering if there could be better enhancements.

Its a very simple tool and is pretty self explanatary.

http://www.saxon-design.co.uk/tools

if you can help me to make a better impression thankyou

alternatively use the tool yourselves.... tis free!!!


daveJam

*two wrongs don't make a right..... but three lefts do!!!!*

 

[Foamcow]

Quick observation.

Please avoid using double quotes as this will error the html output code

Instead of putting a pre-requisite on the user, catch the double quotes and deal with them.

Also, if the person using this tool is doing so because they don't know HTML then is it a bit of an over-reach to expect them to add image links?

Would it not be better to give them an option to upload the image to somwhere on your client's server then automagically insert the link to it?

--
Tek-Tips Forums is Member Supported. Click Here to donate

<honk>*:O)</honk>

Tyres: Mine's a pint of the black stuff.
Mike: You can't drink a pint of Bovril.

 

[Foamcow]

I'm also not sure about the code it's generating

<form name='ebayTemplate'><table valign='top' width=100% bgcolor='#467c47'><div align='center'><center><table border='0' cellpadding='5' cellspacing='5' style='border-collapse: collapse' bordercolor='#000000' width='100%' bgcolor='#467c47'><tr><td width='100%'><div align='center'><center><table border='1' cellpadding='0' cellspacing='0' style='border-collapse: collapse' bordercolor='#000000' width='1000' bordercolorlight='#9F9F9F' bordercolordark='#9F9F9F' bgcolor='#4b3700'><tr><td width='100%'><p align='right' > <font face='verdana' color='#ffe9a5' size='6'></font></p><p align='right'><img border='0' src='bar/bar1.jpg' width='1000' height='20'></p><p align='left'><font face='verdana' color='#ffe9a5' size='4'><b></b></font></td></tr></table></center></div><br><div align='center'><center><table border='1' cellpadding='0' cellspacing='0' style='border-collapse: collapse' bordercolor='#000000' width='1000' bordercolorlight='#9F9F9F' bordercolordark='#9F9F9F' bgcolor='#ffffff'><tr><td width='100%'><table border='0' cellpadding='5' cellspacing='5' style='border-collapse: collapse' bordercolor='#000000' width='100%'><tr><td width='37%'><table border='0' cellpadding='0' cellspacing='0' style='border-collapse: collapse' bordercolor='#000000' width='100%'><tr><td width='100%'><table border='0' cellpadding='5' cellspacing='5' style='border-collapse: collapse' bordercolor='#000000' width='100%'><tr><td width='100%' bgcolor=#4b3700><img width='400' src='[URL unfurl="true"]http://www.saxon-design.co.uk/tools/notass.jpg'></td></tr></table></td></tr></table></td></tr><tr><td[/URL] width='63%' rowspan='2' valign='top'><br><p align='center'><font face='verdana' size='3' color='#006500'></font></td></tr></table></tr><tr><td align='right'><font face='verdana' size='3'>Generated by: </font> <a href='[URL unfurl="true"]http://www.saxon-design.co.uk/tools'><img[/URL] src='mynza.jpg' align='middle' border='0'></a></td></tr></table></center></div></td></tr></table></center></div></form>

Use of tables,font tags and inline styling apart, should the whole thing be wrapped in a form tag? That doesn't seem right since it's not a form.

--
Tek-Tips Forums is Member Supported. Click Here to donate

<honk>*:O)</honk>

Tyres: Mine's a pint of the black stuff.
Mike: You can't drink a pint of Bovril.

 

[Foamcow]

Sorry if this seems like a hatchet job but it's also possible to call external scripts from your tool.
This *may* present a security vulnerability, although I would imagine that eBay would catch them and prevent them being run.
It is indicative that you are perhaps not parsing the output thoroughly though.

--
Tek-Tips Forums is Member Supported. Click Here to donate

<honk>*:O)</honk>

Tyres: Mine's a pint of the black stuff.
Mike: You can't drink a pint of Bovril.

 

[davejam]

thankyou for your response.

i am wrapping it in a form for the photo exchange, tried a few options to avoid a form but as each bit is created dynamically it was, i guess, easier to reference a form

i've been struggling with capturing double quotations... even referencing the chr(34) gives me problems, i would however love to resolve this.

i have spoke to our client about hosting pictures but they're a bit funny about how much of their server this will ultimately use, they also worry about dodgy photos being uploaded to their site....

I have previously worked with ebay sellers who host all of their gunf on photobucket and when a photo is viewed it gives a simple copy and paste link.... they aren't really paying muc for the tool, hence the shabby round the edges ethics, but i do want to provide something thats easy and safe.

do you think that its a handy tool as they wanted to do something that brings in people to their site and came up with the idea because the ceo is a big ebayer, i'm thinking its probably more for personal than internet!!!!

i'll have a look into your suggestions.

thankyou again



daveJam

*two wrongs don't make a right..... but three lefts do!!!!*