Increasing Efficiency(Speed)

Karl Blessing · Jul 19, 2000

right now I've managed to get my page to load in an averaging 3-7 second, as opposed to 13-20 seconds that I had it at before, I have done this to increase the speed, by loading all common recordsets into an array <% @Language=VBScript     %> <% Response.Buffer = True Response.Write Time() & vbcrlf %>   <% Response.Write "<html>" & vbcrlf & "<head></head>" & vbcrlf & "<body " & gLBgcolor & ">" ' Const HID   = 0 Const LID   = 1 Const Name  = 2 Const RType = 3 Const Value = 4 Const Label = 5 Const HP    = 6 Const LP    = 7 Const LangID    = 0 Const LangTab   = 1 Const LangRadio = 2 Const LangType  = 3 Dim Change Change = True Dim HTMLStr Dim HTMLStr1 Dim Count Dim Spaces Count = 0 Spaces = 0 HTMLStr = "" HTMLStr1 = "" Dim RS Dim Conn Dim LangData Dim AryData Set Conn = Server.CreateObject("ADODB.Connection&quot

Set RS = Server.CreateObject("ADODB.Recordset&quot

'Array Loading (Increase added by KJB 7/19/00) 'Results : cut wasted performance down by half, now averages 4-7 seconds, as opposed to 13-20 seconds Set objDB = WebConn() Dim ESA Dim ESA2 Set ESA2 = objDB.EsDataGroup(1) ESA = ESA2.GetRows() ESA2.Close Set ESA2 = nothing Dim RM Dim RM2 Set RM2 = objDB.ProgCompGroup(1) RM = RM2.GetRows() RM2.Close Set RM2 = nothing Dim Occ Dim Occ2 Set Occ2 = objDB.OescodeGroups Occ = Occ2.GetRows Occ2.Close Set Occ2 = nothing Dim IOC Dim IOC2 Set IOC2 = objDB.Sicdiv() IOC = IOC2.GetRows() IOC2.Close set IOC2 = nothing WebDisConn(objDB) Conn.Open "Tree", "sa", "" RS.Open "SELECT Tree.HID, Tree.ID, Tree.Name, InputType.Type, Tree.Val, Tree.Label, Tree.HParent, Tree.LParent FROM Tree INNER JOIN InputType ON Tree.Type = InputType.ID order by Tree.HID, Tree.ID",Conn, 0,1 If not RS.EOF then AryData = RS.GetRows RS.Close end if RS.Open "Select * from LanguageLabel",Conn, 0,1 If not RS.EOF then LangData = RS.GetRows RS.Close end if Set RS = nothing Conn.Close Set Conn = nothing 'end Array Loading AryData has always been there even when it was 13seconds, the increase is by loading those 4 things above into an array , you'll see why in this next function ' sub showtreeat(byref theObj, HpLoc, LpLoc)  Dim TreeRow  TreeRow = UBound(theObj, 2)  for j = 0 to TreeRow   If theObj(HP,j) = HpLoc and theObj(LP,j) = LpLoc then    if Change = true then     If Spaces = 0 then      If count > 45 then       Change = False       HTMLStr1 = HTMLStr       HTMLStr = ""      end if     end if    end if   if theObj(RType,j) <> "DataGroup" then    If Spaces = 0 then     HTMLStr = HTMLStr & "<TR><TD " & gHeader2CellColor & ">"    else     HTMLStr = HTMLStr & "<TR><TD " & gTableCellColor & ">"    end if    writetabs(Spaces)    HTMLStr = HTMLStr & vbcrlf & "<input type=""" & TheObj(RType, j) & """ name=""" & TheObj(Name, j) & """ value=""" & TheObj(Value,j) & """>"    HTMLStr = HTMLStr & TheObj(Label, j)    HTMLStr = HTMLStr & "</TD></TR>" & vbcrlf & vbcrlf    Count = Count + 1   else    select case theObj(Label,j)     case "ESA"      for esloop = LBound(ESA,2) to UBound(ESA,2)       HTMLStr = HTMLStr & "<TR><TD " & gTableCellColor & ">"       writetabs(Spaces)       HTMLStr = HTMLStr & vbcrlf & "<input type=""" & TheObj(Value, j) & """ name=""" & theObj(HID,j) & "_code"" value=""" & Trim(ESA(1,esloop)) & "~" & Trim(ESA(2,esloop)) & """>"       HTMLStr = HTMLStr & ESA(3,esloop) & "</TD></TR>" & vbcrlf & vbcrlf       Count = Count + 1      next     case "RM"      for rmloop = LBound(RM,2) to UBound(RM,2)      HTMLStr = HTMLStr & "<TR><TD " & gTableCellColor & ">"      writetabs(Spaces)      HTMLStr = HTMLStr & vbcrlf & "<input type=""" & TheObj(Value, j) & """ name=""" & theObj(HID,j) & "_code"" value=""" & Trim(RM(1,rmloop)) & "~" & Trim(RM(2,rmloop)) & """>"      HTMLStr = HTMLStr & RM(3,rmloop) & "</TD></TR>" & vbcrlf & vbcrlf      Count = Count + 1     next    case "O"     for oloop = LBound(Occ,2) to UBound(Occ,2)      HTMLStr = HTMLStr & "<TR><TD " & gTableCellColor & ">"      writetabs(Spaces)      HTMLStr = HTMLStr & vbcrlf & "<input type=""" & TheObj(Value, j) & """ name=""" & theObj(HID,j) & "_code"" value=""" & Occ(0,oloop) & """>"      HTMLStr = HTMLStr & Occ(1,oloop) & vbcrlf & "</TD></TR>" & vbcrlf & vbcrlf      Count = Count + 1     next    case "IOC"     for iloop = LBound(IOC,2) to UBound(IOC,2)      HTMLStr = HTMLStr & "<TR><TD " & gTableCellColor & ">"      writetabs(Spaces)      HTMLStr = HTMLStr & vbcrlf & "<input type=""" & TheObj(Value, j) & """ name=""" & theObj(HID,j) & "_ind_grp"" value=""" & IOC(0,iloop) & """>"      HTMLStr = HTMLStr & IOC(1,iloop) & vbcrlf & "</TD></TR>" & vbcrlf & vbcrlf      Count = Count + 1     next    end select   end if  Spaces = Spaces + 1  showtreeat theObj, theObj(HID, j), theObj(LID, j)  Spaces = Spaces - 1  end if next end sub you'll notice at the top I have 3 nested if thens, may be more coding by from my perspective, if Change isnt true, it doesnt test the other two. the red is the part increased in speed by the loading of arrays above and this the helper functions, and the main routine ' '-- Does language lookup on all the Labels -- sub replacelang(byref LangObj, byref AryObj)  for w = LBound(AryObj,2) to UBound(AryObj, 2)   for x = LBound(LangObj,2) to UBound(LangObj, 2)    if AryObj(Label, w) = Cstr(LangObj(LangID, x)) then     AryObj(Label, w) = LangLookup(LangObj(LangTab,x), LangObj(LangRadio,x), LangObj(LangType,x))    end if   next  next end sub '-- Simulates the Tree-Look by throwing in 5 Spaces as tab for each level sub writetabs(number)  for k = 0 to number   HTMLStr = HTMLStr & " "  next end sub ' replacelang LangData, AryData showtreeat AryData, 0,0 set AryData = nothing set LangData = nothing Set ESA = nothing Set RM = nothing Set Occ = nothing set IOC = nothing Response.write "<form action=""FormatMulti.asp"" method=""Post"">" & vbcrlf Response.Write vbtab & "<Table border=0 align=center Width=""90%"">" & vbcrlf Response.Write vbtab & vbtab & "<TR><TD " & gTopColor & " align=center valign=middle colspan=2> <H1> " & LangLookup("Multi", "Report", "Print&quot

& " </H1> </TD></TR>" & vbcrlf Response.Write vbtab & vbtab & "<TR>" & vbcrlf Response.Write vbtab & vbtab & vbtab & "<TD " & gTableCellColor & " width=""50%"" valign=top><Table border=0 width=""100%"">" & vbcrlf & HTMLStr1 & vbcrlf & "</Table></TD>" & vbcrlf Response.Write vbtab & vbtab & vbtab & "<TD " & gTableCellColor & " width=""50%"" valign=top><Table border=0 width=""100%"">" & vbcrlf & HTMLStr  & vbcrlf & "</Table></TD>" & vbcrlf Response.Write vbtab & vbtab & "</TR>" & vbcrlf Response.Write vbtab & vbtab & "<TR><TD " & gBottomColor & " align=center valign=middle colspan=2><input type=""Submit""></TD></TR>" & vbcrlf Response.Write vbtab & "</Table>" & vbcrlf Response.Write "</form>" & vbcrlf Response.write "</body>" & vbcrlf & "</html>" Response.Write Time() & vbcrlf Response.Flush %> My question to you all, is if you can recomend other ways of speeding this up, or sugestions? Karl <a href=mailto:kb244@kb244.8m.com>kb244@kb244.8m.com</a> <a href=

http://kb244.8m.com>

</a> Experienced in : C++(both VC++ and Borland),VB1(dos) thru VB6, Delphi 3 pro, HTML, Visual InterDev 6(ASP(WebProgramming/Vbscript)

http://www.brainbench.com/transcript.jsp?pid=629151

DougP · Jul 19, 2000

Why you already saved 50% What's a couple of seconds in a life span. And how much time did YOU spend making it quicker. Bunches of people are moving to broad band every day. And then it won't matter cause 13-20 seconds becomes 1.5 seconds. DougP <a href=mailto: dposton@universal1.com> dposton@universal1.com</a> <a href= > </a> Ask me how Bar-codes can help you be more productive.

palbano · Jul 19, 2000

> Bunches of people are moving to broad band every day. > And then it won't matter cause 13-20 seconds becomes 1.5 seconds. Wow, did you ever miss the point on that one! Whew! Earth to Doug... anybody home? ;o) -pete

Karl Blessing · Jul 20, 2000

did I mention that timming is based off my LAN network, anyways it needs to be as fast as I Can get it, the customers dont want to wait around for just the start screen(where all the selections are made) they can wait while their request is being processed, in any case, the faster I can get it, the better I can add more to it, and the Timming is done based on how long it takes the page to process then send back, not how long it takes to download it. to download that small HTML would be nearly a split second, but to actually execute some of the stuff on there takes a bit longer, so I really think you misunderstood me. Karl <a href=mailto:kb244@kb244.8m.com>kb244@kb244.8m.com</a> <a href=

http://kb244.8m.com>

</a> Experienced in : C++(both VC++ and Borland),VB1(dos) thru VB6, Delphi 3 pro, HTML, Visual InterDev 6(ASP(WebProgramming/Vbscript)

http://www.brainbench.com/transcript.jsp?pid=629151

AnandMishra · Jul 20, 2000

Karl: You did  a good job. But are you considering the server load too? You are opening quite good number of recordset and taking server resources too. If too many customers are working concurrent then server may face resource problem too. you have to think of locking mechanism also carefully, if more nos. of records are open at given time for each session. It is always better to get good/optimised response time. it also depend upon objective/priorties of application also. Well done. Anand

Karl Blessing · Jul 20, 2000

Actually I'm Only considering the serverside processing, because I know clientside download will vary, running it right off a 10Mbit lan, I can see the smallest speed possible, which in this case varies 3-7 second, which is almost the exact serverside, I have the Time() spit out at the top, then at the bottom, then have the Page flushed to the client, so the Times are the beginning and end, before it's sent to the client, so I'm judging only on serverside processings. Karl <a href=mailto:kb244@kb244.8m.com>kb244@kb244.8m.com</a> <a href=

http://kb244.8m.com>

</a> Experienced in : C++(both VC++ and Borland),VB1(dos) thru VB6, Delphi 3 pro, HTML, Visual InterDev 6(ASP(WebProgramming/Vbscript)

http://www.brainbench.com/transcript.jsp?pid=629151

chiph · Jul 21, 2000

Karl - I agree that you need faster response times.  Rule of thumb in internet delivery is that if the page doesn't appear in 8 seconds, the user will hit the "back" button.  And that applies even if the user has a 14,400 modem! What I might suggest is that you remove parts of your code until you isolate which section is consuming all the time.  Right now (without running any tests), the ReplaceLang function looks suspicious, since you've got a call to LangLookup() inside a double-nested loop. Chip H.

Karl Blessing · Jul 21, 2000

LangLookup is a nessasity, it send 3 parameters, and returns the label that is in the proper language(english, spanish, so on) its in an ActiveX control, the ReplaceLang, goes through the array, and finds every label that matches a number in the language table(which contains the 3 paramters to pass to the control to get back the proper label) right now, just running throught the array replacing them as I find them is the only way I know how. Karl <a href=mailto:kb244@kb244.8m.com>kb244@kb244.8m.com</a> <a href=

http://kb244.8m.com>

</a> Experienced in : C++(both VC++ and Borland),VB1(dos) thru VB6, Delphi 3 pro, HTML, Visual InterDev 6(ASP(WebProgramming/Vbscript)

http://www.brainbench.com/transcript.jsp?pid=629151

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Increasing Efficiency(Speed)

Karl Blessing

Programmer

DougP

MIS

palbano

Programmer

Karl Blessing

Programmer

AnandMishra

Programmer

Karl Blessing

Programmer

chiph

Programmer

Karl Blessing

Programmer

Similar threads

Part and Inventory Search

Sponsor