Include url that contains commas 1

[Zhris]

Hello,

I am trying to include a html file within a php script. I use this code:

$old_url = '[URL unfurl="true"]http://'.$_SERVER[/URL]['HTTP_HOST'].$_SERVER['SCRIPT_NAME'];

$dirname = dirname($old_url);

$include_url = $dirname.'/../Interview-Courses/Other-Info/Introduction/ST, CT, FY Trainees.htm';

include($include_url);

This does nothing (nothing is included). However, if I remove the commas from the html file and change the include_url to $dirname.'/../Interview-Courses/Other-Info/Introduction/STCTFYTrainees.htm' it works as expected.

Is there any reason why using commas effects the include function? In a different script I include the same file, but use the absolute path instead of the full url, which also works as expected.

Thanks in advance,

Chris

 

[feherke]

Hi

Probably because a valid URL can not contain comma. See & use [tt]urlencode()[/tt].

Feherke.

http://rootshell.be/~feherke/

 

[Zhris]

Hi,

Thank you for your fast response.

I just tried encoding the url and recieved the same result.

$include_url = urlencode($include_url);

include($include_url);

Do you have another suggestion? Should I be using the absolute path instead of the url anyway?

Thanks,

Chris

 

[feherke]

Hi

You should not encode the whole string. The characters used to structure the URL should not be encoded.

Feherke.

http://rootshell.be/~feherke/

 

[Zhris]

Thank you again,

Still having the same problem:

$include_url = $dirname.'/../Interview-Courses/Other-Info/Introduction/'.urlencode("ST, CT, FY Trainees.htm");

include($include_url);

Unless this isn't how you meant?

Although it is impracticle, because I will have to make alot of changes across many files, I have used the absolute path instead, which works:

include(getcwd().'/../Interview-Courses/Other-Info/Introduction/ST, CT, FY Trainees.htm');

A friend of mine just suggested that I should encode the url too, therefore I am still baffled as to how to approach my original example.

Thank you very much for your help.

Chris

 

[feherke]

Hi

My mistake, the comma ( , ) is extra character, not unsafe. In you URL only the spaces ( ) has to be encoded.

My mistake, I thought that after having a $_SERVER['SCRIPT_NAME'] in your URL, the rest is query. There the spaces replaced with add signs ( + ) by [tt]urlencode()[/tt] are Ok, however in the path they are not.

This should work :

[navy]$include_url[/navy] [teal]=[/teal] [COLOR=darkgoldenrod]str_replace[/color][teal]([/teal][green][i]' '[/i][/green][teal],[/teal][green][i]'%20'[/i][/green][teal],[/teal][navy]$include_url[/navy][teal]);[/teal]

And sorry.

Feherke.

http://rootshell.be/~feherke/

 

[Zhris]

That worked perfectly. I have only just got back to continue with this and you've saved me a bit of hassle.

Thank you again for your help!

Chris