imagecopy cropping troubles 1

[frozenpeas]

I am trying to copy a part of one image to another. My trouble is that with portrait images, the aspect ratio gets squashed. I have tried the following:

imagecopy($thumb,$thumb_src,0,0,120,90,$newwidth,$newheight);

imagecopyresized($thumb,$thumb_src,0,0,120,90,$newwidth,$newheight);

imagecopyresampled($thumb,$thumb_src,0,0,0,0,120,90,$newwidth,$newheight);

I figured it was because of $newwidth and $newheight... so I tried an if/else to swap them for portrait/landscape. But I got the same result.

Any ideas? Thanks.


frozenpeas

 

[jpadie]

how do you get the new width and height?

you do, of course, need to determine which should be width and height. something like this normally does it.

$maxdimension = 500;
list ($w, $h) = getimagesize($image);
if ($w > $h){
 //landscape
 $newwidth = $maxdimension;
 $newheight = $h * ($maxdimension / $w );
}
if ($w > $h){
//landscape
 $newheight = $maxdimension;
 $newwidth = $w * ($maxdimension / $h );
}
if ($w === $h){
 $newwidth = $newheight = $maxdimension;
}

and the best quality transformation will be with imagecopyresampled on an image created with imagecreatetruecolor or one of file based imagecreates.

 

[frozenpeas]

Thanks, jpadie. I'll give it a try when I get home.

I am getting $newwidth and $newheight from an earlier part in my script... they are the size of the image that this new cropped image is being made from.

frozenpeas

 

[jpadie]

oops the second conditional is incorrect should be

if ($w [red]<[/red] $h){
[red]//portrait[/red]
 $newheight = $maxdimension;
 $newwidth = $w * ($maxdimension / $h );
}

 

[frozenpeas]

Well, hot dog. That worked liked a charm. Thanks!

frozenpeas