Ignoring Directories

[axman505]

I have the following chunk of code. The ignore array contains directory names which should be ignored when outputed. However, there is a flaw in the logic that i cannot figure out, it doesnt work right at all, any suggestions? Thanks.


$ignore =
array(".","..","extlib","images","lib","plugins","schemas","search_templates","tmpl"

if ($handle = opendir('/path/to/folder/')) {

while (false !== ($file = readdir($handle))) {
if (is_dir($file)){
for ($i=0; $i<sizeof($ignore); $i++){
if (preg_match(&quot;/$file/i&quot;,$ignore[$i])) {
print &quot;$file = $ignore[$i]<br>&quot;;
} else {
print &quot;$file<br>&quot;;
}
}
}
}
closedir($handle);
}

 

[sleipnir214]

In situations like this, instead of hardcoding directory entries to ignore, I use PHP's is_dir() function (

http://us4.php.net/function.is-dir)

Want the best answers? Ask the best questions:

http://www.catb.org/~esr/faqs/smart-questions.html

TANSTAAFL!!

 

[axman505]

If you look at my loop, i do make use of the is_dir() function

 

[DRJ478]

A suggestions:

Your ignore list is an array. You need not compare each entry to the filename in a loop every time. Have a look at the in_array() function

http://us3.php.net/manual/en/function.in-array.php

Here's some more compact code:

$ignore =
array(".","..","extlib","images","lib","plugins","schemas","search_templates","tmpl");

if ($handle = opendir('/path/to/folder/')) {

    while (false !== ($file = readdir($handle)))  {
       if (is_dir($file) && in_array($file,$ignore)){
           print &quot;$file ignored<br>&quot;;
       } else {
          print &quot;$file<br>&quot;;
       }
    }
    closedir($handle);
}

 

[axman505]

was not aware of the in_array function, thanks!