if-then-else correct?

[jawon]

Is there something wrong with this statement? The variables come out ok and the files they reference do indeed exist, but when this runs, it jumps to the else statement.

if [ -f $mbdir/v${lastmon}${lastyear}.sas7bdat.gz ] and [ -f $mydir/logs/regcsr_20${year}-${month}-01.txt ] and [[ $day <= 10 ]]
then ghcsas $mydir/rvmetr.sas
else echo &quot;All necessary files do not exist. This sas program did not run.&quot;
fi

 

[iribach]

what's that 'and' are ??
try to configure the value of 'else' ??
make it clear, use a if-cascade not an if-orgie,
try 'case' it's really simpler and efficace.

 

[Annihilannic]

Try:

[tt]if [[ -f $mbdir/v${lastmon}${lastyear}.sas7bdat.gz && -f $mydir/logs/regcsr_20${year}-${month}-01.txt && $day <= 10 ]]
then ghcsas $mydir/rvmetr.sas
else echo &quot;All necessary files do not exist. This sas program did not run.&quot;
fi[/tt]

As iribach pointed out, using &quot;and&quot; is not a valid syntax. Your statement was also using two types of &quot;test&quot;, [, which behaves like /usr/bin/test, and [[, which is the Korn shell built-in version. The above achieves the same using only one test, which should also be more efficient. Annihilannic.

 

[Annihilannic]

Oops, one mistake:

[tt]if [[ -f $mbdir/v${lastmon}${lastyear}.sas7bdat.gz && -f $mydir/logs/regcsr_20${year}-${month}-01.txt && $day -le 10 ]]
then ghcsas $mydir/rvmetr.sas
else echo &quot;All necessary files do not exist. This sas program did not run.&quot;
fi[/tt]

You can't use &quot;<=&quot; to compare integers in this example, you need to use -le instead.

Annihilannic.