IF Statement & Loop 1

[anastasia]

Hi, I am using the following VBScript code within an ASP page. The code is as follows:

<% Do while NOT RS.EOF %>
<% IF RS(&quot;Times&quot = mytime THEN %>
<% errorForm &quot;Correct. &quot; %>
<% ELSE %>
<% errorForm &quot;Not Correct. &quot; %>
<% END IF %>
<%
RS.MoveNext
Loop
%>

Further above in the page I have connected to the database. Other IF statements are before this and work fine. The mytime variable contains a time that a user enters in a form and this is compared to times held in the database, field name is called Times. I am trying to loop through these times and if the time entered by the user is not equal to any times held in the database then the appropriate message is displayed. However the above code seems only to check the first time in the database table and does not continue through the rest.?

I can't see anything wrong in the code, any ideas?

thanks.

 

[link9]

Try sticking this code directly above what you have posted:

if not (rs.eof and rs.bof) then
  rs.movefirst
end if

If it only does one iteration then, then chances are you only have one record in the recordset because the code you posted looks rosey.

Just a note -- cash all those <%'s and %>'s except for two that would completely encapsulate the code fragment. They are not needed, and it will make your code a little more readable.

good luck!
Paul Prewett

 

[gsc1ugs]

I agree rs.movefirst at the begining

 

[anastasia]

Thank you link9 and gsc1ugs for your reply. I have implemented that extra code and end up with correct coming up where the time entered equlas the time in the database and not correct coming up for all the other times, so I know this code is working however I just want the time entered by the user to be checked if it exists in the database and if so the time entered is correct. The way it is working in the above it displays both correct and not correct for all records in the database. I guess I have to use an Exists function somewhere?

 

[link9]

You might try just setting a variable, and then checking the value of that upon exit of the loop

ex)

<% 
dim found
found = false
Do while NOT RS.EOF
  IF RS(&quot;Times&quot;) = mytime  THEN
    found = true
  RS.MoveNext
Loop

if found then
  errorForm &quot;Correct. &quot;
else
  errorForm &quot;Not Correct. &quot;
end if

%>

good luck!
Paul Prewett

 

[link9]

You might try just setting a variable, and then checking the value of that upon exit of the loop

ex)

<% 
dim found
found = false
Do while NOT RS.EOF
  IF RS(&quot;Times&quot;) = mytime  THEN
    found = true
  end if
  RS.MoveNext
Loop

if found then
  errorForm &quot;Correct. &quot;
else
  errorForm &quot;Not Correct. &quot;
end if

%>

good luck!
Paul Prewett

Think I hit the submit button once in error -- If so, please ignore that first post.

 

[anastasia]

Thank you link9 for the above code it works perfect.

However I want the top part before the else to do nothing, I dont want anything to be displayed to the user if mytimes = times. I only want the bottom half to display to the user if mytime doesnt equal times. I have tried if found then end if then else but get an error.

if found then
errorForm &quot;Correct. &quot;
else
errorForm &quot;Not Correct. &quot;
end if

%>

 

[link9]

replace the entire if statement with this:

if not found then
  errorForm "Not Correct. "
end if

just leave off the else altogether and test for 'not' --

 

[anastasia]

Thanks for your reply link9 I now have the following code:

<%
dim found
found = false
Do while NOT RS.EOF
IF RS(&quot;Times&quot = mytime THEN
found = true
end if
RS.MoveNext
Loop

if not found then
errorForm &quot;Not Correct. &quot;
end if

%>

When this code is run it always comes up with the error Not correct even though there is a match in the database.

How do I test in the code for not?

Thanks again.

 

[link9]

Well, you already are -- you are asking if 'not' found...

Boolean expression. And the wrong one at that. I'm sorry... that was my mistake. Take out the 'not' --

if found then
errorForm &quot;Not Correct. &quot;
end if

-paul

 

[anastasia]

Thanks again for your reply, but unfortunately when I remove the not as above it does not display the Not Correct when it should so it is now doing the complete opposite to what it was doing before?

 

[link9]

Ok, above, you said that the following code works perfect...

if found then
errorForm &quot;Correct. &quot;
else
errorForm &quot;Not Correct. &quot;
end if

Take out the action that you do not wish to occur...

 

[anastasia]

Thanks paul. The code works fine, the reason it has not been working is that I had two loops within the code, I was trying to carry out two error checks in loops in the one connection so I took the other out and the code above works great.

Thanks you hve been very patient.

I will give you my vote.