help debugging function

[electricphp]

I have the following function which is not outputting anything when I'm calling it:

<script language=JAVASCRIPT type="TEXT/JAVASCRIPT">
		<!-- Hide script from older browsers

function percentiles(sex,age,value) {

  if (sex == 2) {
    var percentiles_array = girls_bmi;   
 } else {
    var percentiles_array = boys_bmi;   
 }

   for (var i = 0; i < percentiles_array.length; i ++) {
	     data = percentiles_array[i];
		 details = data.split("|");
		 details_age = details[0];
		 if (age == details_age) {
		      var L = details[1];
		      var M = details[2];
		      var S = details[3];
		      break;
		 }		 
   }

  if(L==0) {
    Z = log(value/M)/S
  } else {
    Z = (Math.pow((value/M),L)-1)/(L*S)
  }
   
  P=1-1/Math.sqrt(2*3.14159265)*Math.exp(-Math.pow(Math.abs(Z),2)/2)*(0.4361836*(1/(1+0.33267*Math.abs(Z)))-0.1201676*Math.pow((1/(1+0.33267*Math.abs(Z))),2)+0.937298*Math.pow((1/(1+0.33267*Math.abs(Z))),3))
    if(Z>0) {
      centile = P*100
    } else {
      centile = 100-P*100
    }

    
  return Math.round(centile*10)/10
}
		
		// End hiding script -->
		</script>

The part that's supposed to output the percentile is this:

<script language=JAVASCRIPT type="TEXT/JAVASCRIPT">  
percentile = percentiles(1, 5, 19);
percentile = parseInt(percentile);
document.write("percentile: " + percentile);
</script>

but it's not outputing anything

any help would be appreciated

 

[feherke]

Hi

What is boys_bmi ?

Feherke.

http://rootshell.be/~feherke/

 

[BillyRayPreachersSon]

- log should be Math.log unless you've defined your own log function.

- Do you see any JS errors?

- Are girls_bmi and boys_bmi defined anywhere?

- What do girls_bmi and boys_bmi hold? What format is the data stored in?

Those aside, I'd change this:

percentile = parseInt(percentile);

to this:

percentile = parseInt(percentile[!], 10[/!]);

to stop any potential errors, and this:

<script language=JAVASCRIPT type="TEXT/JAVASCRIPT">

to this:

<script type="text/javascript">

unless you need to support very old browsers.

Hope this helps,
Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

Dan's Page [blue]@[/blue] Code Couch:

http://www.codecouch.com/dan/

Code Couch Tech Snippets & Info:

http://www.codecouch.com/

 

[electricphp]

you guys are right, i need to know the values for the boys and girls array in order for the script to work

 

[BillyRayPreachersSon]

Surely you know your own data structure?



Coedit Limited - Delivering standards compliant, accessible web solutions

Dan's Page [blue]@[/blue] Code Couch:

http://www.codecouch.com/dan/

Code Couch Tech Snippets & Info:

http://www.codecouch.com/