getting element id from a js file 1

[davikokar]

hallo,

I have this code into a js file, it is loaded when I open a webpage. The purpose of the code is to show a different background image each day, looping through the available pictures. The problem is that the last line of the code doesn't seem to work and since I'm not an expert of js I don't know why... any idea?

window.onload = function() {
   var today = new Date();
   var first = new Date(today.getFullYear(),0,1);
   var theDay = Math.round(((today-first)/1000/60/60/24)+.5,0);
   var picNr = 10;
   var picUse;
   picUse = theDay%picNr;

   document.getElementById('Top').style.background='url(../img/'+this.picUse+'.jpg)';
}

 

[feherke]

Hi

document.getElementById('Top').style.background[red]Image[/red]='url(../img/'+this.picUse+'.jpg)';

Feherke.

http://rootshell.be/~feherke/

 

[tsuji]

The main problem of the line, as I see it, is the misunderstood of the scope of this. If picUser is global scope, it would be fine. But it is local to the onload handler, hence, the "this" reference should be taken out.

> document.getElementById('Top').style.background='url(../img/'+[red]this.picUse[/red]+'.jpg)';
[tt]document.getElementById('Top').style.background='url(../img/'+[blue]picUse[/blue]+'.jpg)';[/tt]

 

[feherke]

Hi

Good point tsuji. Have a star for teaching me something new : always scroll to the end of line.

Feherke.

http://rootshell.be/~feherke/