Function doesn't return a value 3

[Mickbw]

I am passing the following function a string value '13-05-2004'. It is supposed to parse out the individual numeric values and see if they are valid month, day, and year values.

function ParseDate(FormField,DateFormat)
		{
		//DateFormat 1 = mmddyyyy, 2 = yyyymmdd
var cFieldValue =	
document.getElementById(FormField).value;
//alert(cFieldValue);

The alert shows 13-04-2004

var dtDate_array=	cFieldValue.split("-");
		alert(dtDate_array[0]+" "+dtDate_array[1]+" "+dtDate_array[2]);

The alert shows 13 04 2004

if(DateFormat = 1)
			//mm-dd-yy format
			{
			alert(parseInt(dtDate_array[0]));

The alert shows 13

if (parseInt(dtDate_array[0]) < 0 && parseInt(dtDate_array[0]) > 12)
				{alert('Bad Month Passed');
				return false;
				}

The alert doesn't show and no value is returned

What am I doing wrong? Thanks for the help.

Have a nice weekend,



Michael Brennan-White
New Hampshire Treasury Department

http://www.nh.gov/treasury

 

[LFI]

The alert never fires because a dtDate_array[0] can never be both less than 0 AND greater than 12. Change your && to || and all should once again be right with the world!

Have a good weekend!

--Dave

 

[scriptOhead]

if(DateFormat = 1)
should be

if(DateFormat == 1)

'=' is an assignment operator so it Gives DateFormat a value of 1.

'==' queries whether it is 1.

 

[BillyRayPreachersSon]

You should also change:

alert(parseInt(dtDate_array[0]));

to read:

alert(parseInt(dtDate_array[0], 10));

Hope this helps,
Dan

 

[Mickbw]

Thanks for all your help,

It is scary that in a small section of code I could make so many errors. Now I can apply your fixes to my entire function.

I feel like I am a pretty good programmer in most errors but Javascript continually has me spinning in a circle. Thanks a lot.



Michael Brennan-White
New Hampshire Treasury Department

http://www.nh.gov/treasury