Form validation using vbscript does not work. Why?

Guest_imported · Apr 3, 2001

Hi guys,
I have an ASP application. I'd like the program to display a message if someone has not entered information in the required fields. The vbscript code does not work. I simply do not get any message display. Here is the code:

<%@ LANGUAGE = "VBSCRIPT"%>
<%OPTION EXPLICIT%>

<html>
<head>
<title>Directory-Panama</title>
</head>
<body bgcolor="#FFFFFF" background="background.gif" text="#000066">




<form action="addpersonexe.asp" name=addpersonform method="post">
<table width="719" border="0" cellspacing="2" cellpadding="0" height="404" align="left">
<tr>
<td valign="top" width="148" height="117"><img src="spacer.gif" width="147" height="11"></td>
<td height="117" align="left" valign="top" colspan="5" width="550"><font size="5" face="Times New Roman, Times, serif" color="#990000"><b><img src="title.gif" width="300" height="63"></b></font>
<font face="Arial, Helvetica, sans-serif" color ="#CC0000" size="2"><br>
<b>Add a Person</b><hr size="0" noshade></font>
<p><font size="2" face="Times New Roman, Times, serif" color="#000080">Fill
out the fields below to enter your information in the database. The
</font><font size="2" face="Times New Roman, Times, serif" color="#FF0000"> *
</font><font size="2" face="Times New Roman, Times, serif" color="#000080"> indicates required information.<br>
<br>
</font></td>
</tr>
<tr>
<td width="148" height="40"> </td>
<td cellspace="0" valign="top" align="left" height="40" width="257"><b>Last
Name <font color="#FF0000">*</font><br>
<input name="lname" size="20" >
</b></td>
<td cellspace="0" valign="top" align="left" height="40" width="9"> </td>
<td width="132"><b>First Name <font color="#FF0000">*</font> <br>
<input name="fname" size="15" >
</b>
<td height="40" width="46"><b>MI</b> <br>
<input name="mi" size="1">
</td>
<td height="40" align="left" valign="top" width="90">
</td>
<td width="7">
<br>
</tr>
<tr>
<td width="148" height="36"> </td>
<td cellspace="0" valign="top" align="left" height="36" width="257"><b> Street
Address<br>
<input name="streetname" size="25">
</b></td>
<td cellspace="0" valign="top" align="left" height="36" width="9"> </td>
<td width="132" cellspace="0" valign="top" align="left" height="36"><b>City<br>
<input name="city" size="15">
</b></td>
<td width="46" valign="top" align="left"><b>State</b> <br>
<input name="state" size="1">
</td>
<td align="left" cellspacing="0" valign="top" height="36" width="90"><b>Zip
Code<br>
<input name="zipcode" size="5">
</b></td>
</tr>
<tr>
<td width="148" height="52"> </td>
<td cellspace="0" valign="top" align="left" height="52" width="257" nowrap><b>Postal
address </b><font size="2"> <font size="1"> </font></font><b><br>
<input name="postal_address" size="30">
<br>
</b></td>
<td cellspace="0" valign="top" align="left" height="52" width="9" nowrap><b>
</b></td>
<td cellspace="0" valign="top" align="left" height="52" colspan="3" width="276"><b>Country
<font color="#FF0000">*</font></b><br>
<%
Dim myRS, country
Response.Write "<select name = 'country'>"
Response.Write "<option value=''>Choose a Country</option>"
Set myRS = Server.CreateObject("ADODB.Recordset&quot

myRS.Open "SELECT * FROM country order by country", myConn
While Not myRS.EOF
country = myRS("country&quot

Response.Write "<option value = '" & country & "'>"
Response.Write country & "</option>"
myRS.MoveNext
Wend
Response.Write "</select>"
myRS.Close
%>
</td>
</tr>
<tr>
<td width="148" height="49"> </td>
<td width="257" cellspace="0" valign="top" align="left" height="49"><b>Primary
telephone number<br>
<input name="telephone1">
</b></td>
<td cellspace="0" valign="top" align="left" height="49" width="9">
<p align="left"> </p>
</td>
<td cellspace="0" valign="top" align="left" height="49" colspan="3" width="276"><b>Alternate
telephone number<br>
<input name="telephone2">
</b></td>
</tr>
<tr>
<td width="148"> </td>
<td width="257" align="left" valign="top"><b>Primary email <font color="#FF0000">*</font><br>
<input name="email1">
</b>
<td width="9" align="left" valign="top">
<td colspan="3" align="left" valign="top" width="276"><b>Alternate email<br>
<input name="email2">
</b>
<tr>
<td width="148"> </td>
<td colspan="5" align="left" valign="top" width="550"><b><br>
Website</b><br>
<input name="website" size="35">
<tr>
<td width="148"> </td>
<td width="257" align="left" valign="top"><b>
Type of Business:<font color="#FF0000">*</font></b><br>
<%
Dim btype
Response.Write "<select name = 'type'>"
Response.Write "<option value=''>Choose a Business Category</option>"
Set myRS = Server.CreateObject("ADODB.Recordset&quot

myRS.Open "SELECT * FROM worktype order by type", myConn
While Not myRS.EOF
btype = myRS("type&quot

Response.Write "<option value = '" & btype & "'>"
Response.Write btype & "</option>"
myRS.MoveNext
Wend
Response.Write "</select>"
myRS.Close
Set myRS= Nothing
myconn.Close
Set myConn= Nothing
%>
</td>
<td width="9" align="left" valign="top"> </td>
<td colspan="4" align="left" valign="top" width="287"><b>
Describe your type of business:<br>
<textarea name="description" cols="20" rows="1"></textarea>
</b>
</tr>
<tr>
<td width="148"> </td>
<td width="257" align="right" valign="top"> <br>
<input type="submit" value="Add entry" name="Submit">
<td width="9" align="right" valign="top">
<td colspan="4" align="left" valign="top" width="287"> <br>
<input type="reset" value="Clear">
</tr>
<script language=VBScript>
Sub btnSubmit_OnClick()
If Len (frmaddpersonform.txtlname.value) = 0 then
Alert "You must enter your last name"
addpersonform.lname.focus
Exit sub
ElseIf Len (frmaddpersonform.txtfname.value) = 0 then
Alert "You must enter your first name"
addpersonform.fname.focus
Exit Sub
End if
Call frmaddpersonform.submit()
end sub
</script>

<tr>
<td width="148"> </td>
<td colspan="6" align="left" valign="top" width="561">
<hr noshade size="0" align="center">
<font size="1"><a href="index.html">Home</a>|<a href="searchpersonform.asp">People Search</a>| Organization/Business Search |<b>Add
personal record</b>| Add business/organization record</font> <br>
<hr size="0" noshade align="center">
<a href="mailto:itzel@mail.utexas.edu"><font size="2">itzel@mail.utexas.edu</font></a><font size="2"><br>
<font size="1">University of Texas<br>
Graduate School of Library and Information Science</font></font></td>
</tr>
</table>
</cfform>
</body>
</html>
</script>

link9 · Apr 3, 2001

I changed a few things around -- First, I changed your submit button to a regular old button -- and gave it an onClick event of the function (which I also renamed for my own preference)...

Then, you were asking for frmaddpersonform -- or something like that, when your actual form name was addpersonform, so that's all you should have asked for... same with your text boxes. They were named fname and lname, but you were asking for txtlname, and txtfname (Sounds like you have been doing some vb, but even there, you have to name your stuff whatever you want to refer to them by) --

Anywho, without further ado, here's what I came up with and tested. Worked fine for me.

...

Code:

      <input type=&quot;button&quot; value=&quot;Add entry&quot; name=&quot;Submit&quot; onClick=&quot;submitThis()&quot;>
    <td width=&quot;9&quot; align=&quot;right&quot; valign=&quot;top&quot;>  
    <td colspan=&quot;4&quot; align=&quot;left&quot; valign=&quot;top&quot; width=&quot;287&quot;> <br>
      <input type=&quot;reset&quot; value=&quot;Clear&quot;>
  </tr>
<script language=VBScript>
Sub submitThis()
If addpersonform.lname.value = &quot;&quot; then
alert &quot;You must enter your last name&quot;
addpersonform.lname.focus
Exit sub
ElseIf Len (addpersonform.fname.value) = 0 then
Alert &quot;You must enter your first name&quot;
addpersonform.fname.focus
Exit Sub
End if
Call addpersonform.submit()
end sub
</script>

I only posted the portion of the code that I changed to get it to work.

good luck!

Paul Prewett

link9 · Apr 3, 2001

Just as a note, I'm not sure that the Call addpersonform.submit() is going to do the trick --

I know it works in javascript, but I don't use client side vbscript -- so I'm not sure about it...

Maybe someone else can confirm or deny that.

Mighty · Apr 4, 2001

It's worth noting that Netscape does not support client side VBScript (unless you go an purchase a third party add-on). So unless your users are exclusively IE, it's probably a better idea to use Javascript for the client side stuff.

Unfortunately, I found this out the hard way after coding all the client side in VBScript before testing in Netscape. Mise Le Meas,

Mighty

scroce · Apr 6, 2001

link 9 (since you rewrote this code), or anyone...

I was scanning this thread, and I am doing something similar to what mcclareni is doing.

I follow the logic of your code example above for form field validation and it does work for me. However a funny thing keeps happening. The code catches validations (like if a field is left blank)gives me my appropriate error message, but then still processes the form and brings me to my asp page. I'm looking for something like a "cancel event" command somewhere that would stop the browswer from executing the action in the form tag.

An analogy in the previous code example would be if
1. you left lname field blank
2. the code generated an alert "You must enter your last name"
3. and instead of canceling the all processsing and forcing the user back to that field on AddPersonForm, AddPersonExe.asp runs anyway

I tried putting in something like:

frmAddPersonForm_OnSubmit = False

but that didn't seem to work.

Any ideas?

PS - I copied the code below (from this example)for easier reference.

<form action="addpersonexe.asp" name=addpersonform method="post">

<input type="button" value="Add entry" name="Submit" onClick="submitThis()">
<td width="9" align="right" valign="top">
<td colspan="4" align="left" valign="top" width="287"> <br>
<input type="reset" value="Clear">
</tr>
<script language=VBScript>
Sub submitThis()
If addpersonform.lname.value = "" then
alert "You must enter your last name"
addpersonform.lname.focus
Exit sub
ElseIf Len (addpersonform.fname.value) = 0 then
Alert "You must enter your first name"
addpersonform.fname.focus
Exit Sub
End if
Call addpersonform.submit()
end sub
</script>

link9 · Apr 6, 2001

Well, like I said in the post up there, I wasn't sure that the formName.submit() would work in vbscript -- and as it turns out, it doesn't --

To be honest, I would do form validation with client side javascript such as what we were talking about over in the ASP forum earlier today.

The reason I say that is that client side vbscript is proprietary to Internet Explorer, so anyone looking at your page in Nutscrape would not be able to take advantage of the form validation -- and futhermore, if you submit the form with the function, it wouldn't even be submitted by NS.

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Form validation using vbscript does not work. Why?

Guest_imported

New member

link9

Programmer

link9

Programmer

Mighty

Programmer

scroce

MIS

link9

Programmer

Similar threads

Part and Inventory Search

Sponsor