form element coming up as undefined 1

[billycat]

I have a radio button named R1 .. but when i call it, it comes up as undefined.

<input type="button" class="formfield" value="submit" onClick="window.location=self.location.href.split('?')[0] + '?row=' + document.myform.mylist.value + '&value=' + this.form.values.value + '&set=1' + '&r1=' + document.myform.R1.value;">

 

[feherke]

Hi

Let us color it up abit.

[red]<[/red][purple][b]input[/b][/purple] [blue]type[/blue]=[i]"button"[/i] [blue]class[/blue]=[i]"formfield"[/i] [blue]value[/blue]=[i]"submit"[/i] [blue]onClick[/blue]=[i]"window.location=self.location.href.split('?')[0] + '?row=' + document.myform.mylist.value + '&value=' + this.form.values.value + '&set=1' + '&r1=' + document.myform.R1.value;"[/i][red]>[/red]

Now go and give it a [tt]name[/tt] attribute...

Feherke.

http://rootshell.be/~feherke/

 

[billycat]

what do u mean exactly?

 

[billycat]

this is the radio

		<input type="radio" value="AND" name="R1" id="R1"><b><font size="1">AND</font></b>
	
	
		<input type="radio" value="OR" name="R1" id="R1"><b><font size="1">OR
		
		</font>

 

[feherke]

Hi

Ah, nothing. I misunderstood the situation.

Feherke.

http://rootshell.be/~feherke/

 

[BabyJeffy]

So... you have 2 radio buttons... sharing the same ID. This is not valid markup (IDs are supposed to be unique). They can share the same name, but they cannot share the same ID.

See if removing the ID fixes it for you

Cheers,
Jeff

[tt]Jeff's Page @ Code Couch

http://www.codecouch.com/jeff/blog/

http://www.coedit.co.uk/

[/tt]

What is Javascript? FAQ216-6094

 

[BillyRayPreachersSon]

This:

document.myform.R1.value;

should be:

document.myform.R1[!][0][/!].value;

to access the first radio, or this:

document.myform.R1[!][1][/!].value;

to access the second.

Hope this helps,
Dan

Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[billycat]

I did that, and this.form.R1.value = undefined still.

 

[billycat]

ok i got that working... now would i tell which one was clicked?

 

[monksnake]

On the very end of your query string:

&r1=' + document.myform.R1.value;">

I recommend making a global variable whose value is set to the currently checked radio button. Put an onclick handler on each radio button that will check to see which button is checked and then reset the global variable if needed.

Then on your query string, you only need to add that variable to the end:

&r1=' + globalVariable">

<.

 

[BillyRayPreachersSon]

Or, simply loop around the R1 collection, checking to see which one is selected, than appen that variable.

Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[billycat]

that is past my JS knowledge

 

[monksnake]

<.

 

[billycat]

ok so this is my attempt.

var r1 = 1;
function value(a) {
a = r1
return r1
}

then this is my radio

		<input type="radio" value="AND" name="R1" onClick="value(and); "><b><font size="1">AND</font></b>
	
	
		<input type="radio" value="OR" name="R1" onClick="value(or); "><b><font size="1">

 

[monksnake]

Cool, glad to see you attempted it.

change the following:

<input type="radio" value="AND" name="R1" onClick="setValue(this); "><b><font size="1">AND</font></b>
<input type="radio" value="OR" name="R1" onClick="setValue(this); "><b><font size="1">

//Set r1 initially to what the radio button is initially set to, if it is not initially set, in most cases it should be
var r1 = false;
function setValue(obj) {
   r1 = obj.value;
}

Querystring call:

<input type="button" class="formfield" value="submit" onClick="window.location=self.location.href.split('?')[0] + '?row=' + document.myform.mylist.value + '&value=' + this.form.values.value + '&set=1' + '&r1=' + [!]r1[/!]">

<.

 

[billycat]

thats alot man! learning alot.

 

[monksnake]

No problem.

<.