For Each loop concatenate results 2

[woter324]

Hi all,

I am sure this is an easy one, but I think the seasonal effects of Muld Wine are getting to me.

I am trying to join / concatenate the output of the for loop.

Here is my code:

wscript.Echo sCase("john smith went shopping")

Function sCase(strSentence)
aSentence = Split(strSentence," ")
For Each word In aSentence
	intWord = Len(word)
	strFirstLetter = UCase(Left(word, 1))
	strRemainingLetters = LCase(Right(word, intWord - 1))
	strWord = strFirstLetter & strRemainingLetters
Next
strWord1 = strWord & " " & strWord
sCase = strword1
End Function

I want it to return "John Smith Went Shopping" but it only returns "Shopping Shopping"

I am sure I have done this several time before, but I just can't work it out at the moment :-(.

Many thanks

Tex

 

[Foada]

The line

strWord = strFirstLetter & strRemainingLetters

is getting over written in each iteration of the loop. You will need to do something like

sCase = sCase & strFirstLetter & strRemainingLetters & " "

Also the lines

strWord1 = strWord & " " & strWord
sCase strword1

are not needed but you could use

sCase = RTrim(sCase)

to get rid of the trailing " " (space)


If you choose to battle wits with the witless be prepared to lose.

 

[PHV]

What about this ?

Function sCase(strSentence)
For Each word In Split(strSentence)
  strWord = strWord & " " & UCase(Left(word, 1)) & LCase(Mid(word, 2))
Next
sCase = Mid(strWord, 2)
End Function

Hope This Helps, PH.
FAQ219-2884
FAQ181-2886

 

[woter324]

Foada,

Thanks very much. I was close, but working on the wrong line. I could see it was overwriting but not at that point. Doh.

Here's what I now have:

Function sCase(strSentence)
aSentence = Split(strSentence," ")
For Each word In aSentence
	intWord = Len(word)
	strFirstLetter = UCase(Left(word, 1))
	strRemainingLetters = LCase(Right(word, intWord - 1))
	sCase = sCase & strFirstLetter & strRemainingLetters & " "
Next
End Function

Thanks again.

 

[woter324]

PHV,

So simple. Thank you very much.

Thanks

Tex

 

[Foada]

Glad to help.

If you choose to battle wits with the witless be prepared to lose.