Find when BlindUp/BlindDown ended 1

[Sleidia]

Hi guys,

I use the functions BlindUp/BlindDown from the effects file of the Prototype/Scriptaculous library (functions that I don't fully understand) :

Effect.BlindUp = function(element) {
  element = $(element);
  element.makeClipping();
  return new Effect.Scale(element, 0,
    Object.extend({ scaleContent: false,
      scaleX: false,
      restoreAfterFinish: true,
      afterFinishInternal: function(effect) {
        effect.element.hide().undoClipping();
      }
    }, arguments[1] || { })
  );
};

Effect.BlindDown = function(element) {
  element = $(element);
  var elementDimensions = element.getDimensions();
  return new Effect.Scale(element, 100, Object.extend({
    scaleContent: false,
    scaleX: false,
    scaleFrom: 0,
    scaleMode: {originalHeight: elementDimensions.height, originalWidth: elementDimensions.width},
    restoreAfterFinish: true,
    afterSetup: function(effect) {
      effect.element.makeClipping().setStyle({height: '0px'}).show();
    },
    afterFinishInternal: function(effect) {
      effect.element.undoClipping();
    }
  }, arguments[1] || { }));
};

I call those functions from a script of mine as follow :

    function ad_toggle ( action , num ) {

    var title = document.getElementById( 'ti' + num );
    var content = document.getElementById( 'co' + num );
    var text = document.getElementById( 'te' + num );
    var caption = document.getElementById( 'ca' + num );
    
        if (action == 'open') {

            if (content.style.display != 'none') {
    
            Effect.BlindUp(content);
            title.className = 'closed';
            caption.className = 'on';
            
            } else {
            
            Effect.BlindDown(content);
            title.className = 'open';
            caption.className = 'off';
            
            }
        
        } else {
        
            if (content.style.display == 'none') {
            
                if (action == 'turnon') {
        
                title.className = 'open';
                caption.className = 'hover';
                
                }
                
                if (action == 'turnoff') {
        
                title.className = 'closed';
                caption.className = 'on';
                
                }
            
            }
        
        }
    
    }

The problem is that I want to prevent my function ad_toggle from doing anything before BlindUp/BlindDown have completed their respective task (until a div is fully open/closed).

So, my question is : how do I detect this, and is it possible without changing the code of the Prototype/Effects library?

Thanks a lot for the help

 

[BillyRayPreachersSon]

Every effect can have the following 4 options:

beforeStart: Called before the main effects rendering loop is started.
beforeUpdate: Called on each iteration of the effects rendering loop, before the redraw takes places.
afterUpdate: Called on each iteration of the effects rendering loop, after the redraw takes places.
afterFinish: Called after the last redraw of the effect was made.

So, give your effects an 'afterFinish' option which calls the code you want to run only after the effects have finished. e,g:

Effect.BlindUp(content, { afterFinish:yourFunc });

Hope this helps,
Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

Dan's Page [blue]@[/blue] Code Couch:

http://www.codecouch.com/dan/

Code Couch Tech Snippets & Info:

http://www.codecouch.com/

 

[Sleidia]

Thanks a lot Dan

But I don't see how the call to another function could prevent ad_toggle from doing anything

Any idea?

 

[BillyRayPreachersSon]

It doesn't... you have to move the code from ad_toggle into a new function which only executes after the effects have finished.

Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

Dan's Page [blue]@[/blue] Code Couch:

http://www.codecouch.com/dan/

Code Couch Tech Snippets & Info:

http://www.codecouch.com/

 

[Sleidia]

Ahhh sorry, I think I failed to make something clear enough : it's the functions BlindUp/BlindDown ALSO that I need to prevent from executing while they already are being executed.

 

[BillyRayPreachersSon]

You could use a simple global boolean which you set at the top of ad_toggle, and only clear in the 'afterFinish' function...

I'm guessing you don't want to go into queue behaviour with scriptaculous, so that's probably your easiest bet.

Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

Dan's Page [blue]@[/blue] Code Couch:

http://www.codecouch.com/dan/

Code Couch Tech Snippets & Info:

http://www.codecouch.com/

 

[Sleidia]

Thanks Dan, I managed to do what I wanted thanks to you.
It was easier than I thought

Have a nice day.