file upload woes

[Bastien]

trying to upload a file to the server in secure area...its just not working for me...what am I doing wrong? destination folder has 0777 permissions

    $uploaddir = "/services3/i/n/xxxxxxxx.com/secure/app/data/";
    $uploadfile = $uploaddir . basename($_FILES['userfile']['name']);

    echo '<pre>';
    if (move_uploaded_file(basename($_FILES['userfile']['tmp_name']), $uploadfile)) {
        echo "File is valid, and was successfully uploaded.\n";
    } else {
        echo "Possible file upload attack!\n";
    }

    echo 'Here is some more debugging info:';
    print_r($_FILES);

    print "</pre>";

Bastien

I wish my computer would do what I want it to do,
instead of what I tell it to do...

 

[jpadie]

when you say it is not working, what is the error message? is the file uploaded to the temp directory properly? is there anything in the $_FILES[error] element?

double check the permissions in the uploaddir.

if (!is_writable($uploaddir)) {echo "directory not writable";}else{echo "directory writable";}

 

[Bastien]

no error, 777 permissions on both script and destination folder...file seems to be uploaded to the tmp dir.

Could it be something to do with the moving from perhaps a temp dir that is not ssl secured, to a ssl secured folder?

Bastien

I wish my computer would do what I want it to do,
instead of what I tell it to do...

 

[jpadie]

ssl should only bite on the webserver, not on the fileserver (unless you are expressly using ssl as a vpn for file transfers).

if the script I posted above returns directory is writable on the destination directory then all is fine.

but your move_uploaded_file is wrong. the first parameter must be the full filename (including the path)

if (move_uploaded_file($_FILES['userfile']['tmp_name'), $uploadfile)) {
        echo "File is valid, and was successfully uploaded.\n";
    } else {
        echo "Possible file upload attack!\n";
    }

i suspect that this is the problem as move_uploaded_file will have been looking for a source in the current working directory which is unlikely (not not impossible) to be the upload directory.

 

[Bastien]

The issue turned out to be how the server defined the uploaded file. It required the full path, not the basename of the tmp-name

Bastien

I wish my computer would do what I want it to do,
instead of what I tell it to do...

 

[jpadie]

that's what I said...

but your move_uploaded_file is wrong. the first parameter must be the full filename (including the path)