fgets agony! 1

[tdkratboy]

Hello all, was wondering if there was anyone who could possiblly explain to me an alternative method of reading a file stream? I am using 'fgets' to read a phrase from a text file, the MSDN specifies that it reads until a \n, a null, or the amount of characters specified is encountered. However All of my strings are coming up with a [] square looking character at the end of the string when I output them. Can anyone give me any insight into what is actually going on? However if I shorten the specified characters i.e. fgets(string, 10, stream) and the stream is 20 characters long, the square does not show up. If anyone could assist I'd greatly appreciate it. Thanx in advance! NOTE: I am trying to output to a ListView column using the ListView_SetItem WIN32 function call.

 

[mingis]

It is the '\n' itself.

http://msdn.microsoft.com/library/d...ry/en-us/vclib/html/_crt_fgets.2c_.fgetws.asp

:

fgets reads characters from the current stream position to and including the first newline character, to the end of the stream

 

[olded]

Hi:

minigis is right about the '\n'. When using fgets, I eliminate it. OK, I'm a unix guy, but I would think the following code stub would work under windows:

#include <stdio.h>

int main (void)
{
char buf[10];

fgets(buf, 10, stdin);
if (*buf != '\0')
buf[strlen(buf) - 1] = '\0';

printf("buf is: %s\n", buf);

}

 

[Hammer]

It's better to check for the existance of a character before overwriting the position where you 'think' there is one. Remember that there are occasions when fgets() won't put a \n at the end of the string.

Here's another version of the code:

#include <stdio.h>
#include <string.h>

int main(void)
{
  char buf[BUFSIZ];
  
  if (fgets(buf, sizeof(buf), stdin) != NULL)
  {
    char *p;
    if ((p = strchr (buf, '\n')) != NULL)
    {
      *p = '\0';
    }
    
    printf (">%s<\n", buf);
  }
  
  return(0);
}

There are many other ways to achieve the same result.