Error on cancel in Dialogs (Delphi 7) 2

[ug505]

There's gotta be something I'm missing but I don't know what! It works fine when opening files but if you ever hit cancel it will show a error. What is wrong with this code?

OpenDialog1.Execute;
Memo1.Lines.LoadFromFile(OpenDialog1.FileName);
Form1.Caption:=OpenDialog1.FileName;
Run1.Enabled:=True;

 

[Glenn9999]

OpenDialog1.Execute is a function which returns a boolean value indicating whether a file was selected or not.

if OpenDialog1.Execute then
  bla bla bla

I'm waiting for the white paper entitled "Finding Employment in the Era of Occupational Irrelevancy

 

[smays]

The Execute method of TOpenDialog returns a boolean value. If the cancel button was pressed, false is returned and there is no filename, therefore the TMemo has no file to open. I am confident the TMemo is raising the exception (error) with which you are dealing. All the code following the "OpenDialog1.Execute;" statement needs to be contained in an IF statement.

if OpenDialog1.Execute then
Memo1.Lines.LoadFromFile(OpenDialog1.FileName);
Form1.Caption:=OpenDialog1.FileName;
Run1.Enabled:=True;

Steve.

 

[roo0047]

Steve - minor omission...

  if OpenDialog1.Execute then begin
    Memo1.Lines.LoadFromFile(OpenDialog1.FileName);
    Form1.Caption:=OpenDialog1.FileName;
    Run1.Enabled:=True;
  end;

Roo
Delphi Rules!

 

[smays]

Thanks for catching that!

Steve.