Error handler only works once in loop 1

[may1hem]

I'm looping through a collection of items and I'm deliberately creating an error, just to test the error handler.

The error trap works correctly for the first item in the FOR..NEXT loop, but on the second item it doesn't work and instead Outlook brings up an error message "type mismatch".

Of course I understand the error, but why doesn't the error trap work the second time around?

----------------------------------
Set ol = CreateObject("Outlook.Application")
Set myNameSpace = ol.Application.GetNamespace("MAPI")
Set myFolder = myNameSpace.Folders("myNotes")
Dim myInteger As Integer
Dim myItems As Outlook.Items
Set myItems = myFolder.Items
For Each myitem In myItems
On Error GoTo myErrorHandler
myInteger = cint("abc")
myErrorHandler:
If Err.Number <> 0 Then
msgbox "Error handled"
End If
Next myitem
----------------------------------

 

[SkipVought]

Hi,

2 things. The On Error belongs outide the loop. Clear the error if there is one.

    Set ol = CreateObject("Outlook.Application")
    Set myNameSpace = ol.Application.GetNamespace("MAPI")
    Set myFolder = myNameSpace.Folders("myNotes")
    Dim myInteger As Integer
    Dim myItems As Outlook.Items
    
    Set myItems = myFolder.Items
    [b]
    On Error GoTo myErrorHandler
    [/b]
    For Each myitem In myItems
       myInteger = CInt("abc")
myErrorHandler:
       If Err.Number <> 0 Then
          MsgBox "Error handled"[b]
          Err.Clear[/b]
       End If
    Next myitem

    On Error GoTo 0    'turn off error handling

'set objects to nothing
    Set myItems = Nothing
    Set myFolder = Nothing
    Set myNameSpace = Nothing
    Set ol = Nothing

Skip,
^{Don't let the Diatribe...
talk you to death!}
_{Just traded in my old subtlety...
for a NUANCE!}

 

[combo]

You need to clear the error:
If Err.Number <> 0 Then
Err.Clear
msgbox "Error handled"
End If

combo

 

[PHV]

Furthermore, I'd use the Resume instruction ...

Hope This Helps, PH.
FAQ219-2884
FAQ181-2886

 

[SkipVought]

On second thought, I'd use On Error Resume Next, rather than GoTo, which is basically how you are coding the loop. myErrorHandler: not necessary that way.

Skip,
^{Don't let the Diatribe...
talk you to death!}
_{Just traded in my old subtlety...
for a NUANCE!}