Error - A number is required - works in v8.5 and not in v10

[jraheja]

Following code works in v 8.5 but gives error in v10 - number is required at location "perc:= Round((Sum ({@inc1}) / ToNumber ({@amt_display}) * 100) - 100,0)" ...Why?
----------------------------------------

stringvar percent;
numbervar perc;

if {@amt_display} <> 0 AND Sum ({@inc1}) <> 0
then perc:= Round((Sum ({@inc1}) / ToNumber ({@amt_display}) * 100) - 100,0)
else if {@amt_display} = 0 AND Sum ({@inc1}) = 0
then perc:=0
else if {@amt_display} = 0
then perc:=100
else if Sum ({@inc1}) = 0
then perc:=0;

percent :=ToText(truncate(perc),0) + " %

 

[Madawc]

I'm not an expert on variables - I prefer to use formual fields - but since no one else has answered, I'll have a go.

I'm suspicious first of the percent :=ToText(truncate(perc),0) + " %" at the end. Try commenting it out - put // in front - and see if that works.

The other thought I had was to change 100) - 100,0) to 100) - 100, 0); new versions of software are often fussier about grammer.


Madawc Williams (East Anglia, UK)

 

[ShortyA]

What are the variable types for @AmtDisplay and @Inc1 as this may be the problem if they are not numerics ?

ShortyA

 

[jraheja]

Hi guys! The last statement does not give errors. The ; did not help. I have noted the error is at runtime. Can it be a data error???

@amt_display is defined as -
WhilePrintingRecords;
CurrencyVar Amount;

@inc1 is defined as
if Year({Prod_Trans.Prod_Trans_Dte}) = {@year} and
Month({Prod_Trans.Prod_Trans_Dte}) = {@mon1}
then {Prod_Trans.Clb_Comm_Amt}
else 0

Both did not give compiling errors...

 

[Naith]

Is it possible for {Prod_Trans.Clb_Comm_Amt} to be null?

If there isn't a NOT NULL constraint applied at a database level, try prefixing your formula with:

if
(
isnull({Prod_Trans.Clb_Comm_Amt}) and
Year({Prod_Trans.Prod_Trans_Dte}) = {@year} and
Month({Prod_Trans.Prod_Trans_Dte}) = {@mon1}
)
then 0
else
if Year({Prod_Trans.Prod_Trans_Dte}) = {@year} and
Month({Prod_Trans.Prod_Trans_Dte}) = {@mon1}
then {Prod_Trans.Clb_Comm_Amt}
else 0

Additionally, run the same check and fix against your date field.

Naith

 

[jraheja]

I tried this and it still gave me error. Is it wrong??? This is someone else's code and database and I am maintaining it now - the reports...

if
(
isnull({Prod_Trans.Clb_Comm_Amt}) and
Year({Prod_Trans.Prod_Trans_Dte}) = {@year} and
Month({Prod_Trans.Prod_Trans_Dte}) = {@mon1}
)
then 0
else
if
(isnull ({Prod_Trans.Prod_Trans_Dte})) then 0
else
if
Year({Prod_Trans.Prod_Trans_Dte}) = {@year} and
Month({Prod_Trans.Prod_Trans_Dte}) = {@mon1}
then {Prod_Trans.Clb_Comm_Amt}
else 0

 

[Naith]

Have you also tested for null values against the datefield and {@amt_display}?

 

[jraheja]

@amt_display as stated aerler just had a declaration. Date I have checked above "if
(isnull ({Prod_Trans.Prod_Trans_Dte})) then 0"