EOF Problem

Es · Aug 5, 2000

I am trying to open a Text file ( Notepad) with Open / Input and Output commands. The text file contains a series of comma delinated words that will be then stored in a datastructure before ammending the data and saving back out to a text file. Unfortunatly, although this worked once I now cannot open the text file without receiving a "input past EOF" error message. I cannot resolve this issue and must use the existing structures and text files. For college assessment. Can anyone advise me what to do next. Enclosed copy of appropriate code. Thnaks in advance. Private Sub mnuOpenFile_Click() Dim filesaved, fileedited As Boolean Dim index As Integer Dim filenumber As Integer Dim reg, stats As String Dim ctype As Integer Dim premiles As Long Dim serv As String cdlgBox.InitDir = App.Path cdlgBox.Filter = "textFiles(*.txt)¦*.txt¦AllFiles(*.*)¦*.*" cdlgBox.FilterIndex = 1 cdlgBox.ShowOpen filenumber = FreeFile Open cdlgBox.filename For Input As #filenumber index = 0 Do Until ((EOF(1) = True) And (index < max)) index = index + 1 With CarList.Cars(index) Input #filenumber, .CarReg, .CarType, .LastService, .PreviousMileage, .Status 'reg, ctype, serv, premiles, stats End With Loop Close #filenumber CarList.CarCount = index filesaved = False  fileedited = False    If CarList.CarCount > max Then  MsgBox "Car List is Full"  End If     End Sub

blurred · Aug 5, 2000

i believe you should put the loop like this Do while not EOF(1)   if (index > max) then exit do   'or if (index >= max) then exit do   index = index + 1  With CarList.Cars(index) Input #filenumber, .CarReg, .CarType, .LastService, .PreviousMileage, .Status 'reg, ctype, serv, premiles, stats End With Loop the way i see your loop uses 'AND' so both condition must be true in order for the loop the break loose, since most likely the EOF(1) will be true first but index still < max, so another input will generate that input past EOF error msg. good luck.

WilMead · Aug 7, 2000

Hmmm, Blurred is almost 100% correct.   The original logic doesn't work. In programming, doing something until something is broke is almost never a good idea.  It's usually better to do it while it's OK. Besides all that there is another problem that might cause a break down in both solutions... It's best to test the file you are reading. EOF(1) should be coded EOF(filenumber). I'm a purist and believe that even index and max should be based on information (UBound/LBound) gathered from they object they relate to, but that's another story. Wil Mead <a href=mailto:wmead@optonline.net>wmead@optonline.net</a> <a href= > </a>

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

EOF Problem

Es

Programmer

blurred

Programmer

WilMead

IS-IT--Management

Similar threads

Part and Inventory Search

Sponsor