Debugging for realine() on closed filehandle

[szzxy]

Dear Programmers,
Please help me debug the following perl script. Thanks in advance!
I keep getting the same error msg "readline() on closed filehandle file1 at drug_list_formidterm.pl line 12."


#!usr/local/bin/perl -w
use strict;

my @table;
my $drug;
my $category;
my $line;

open (file1, $ARGV[0]);
open (file2, ">tab_delimited.txt");

while (<file1>){

if ($_=~/^(.+)\t(.+)$/){

$drug=$1;
$category=$2;
$line=$drug."\t".$category;
}
push (@table, $line);





}
foreach my $seq(@table){
print file2 "$seq.\n";
}

close (file1);
close (file2);


Regards,
novice for perl

 

[dkyrtata]

I would guess that your first open() statement failed. So your <file1> statement in the while-loop (at line 12) cannot read the unopened file.

What is in $ARGV[0]? Make sure it contains a proper file name (preferably fully qualified with a path) and is accessible with read permission.

Also, try hard-coding different file names in the open() to see what happens.

 

[max1x]

For starters:

$fileName = $ARGV[0] || die "No file name provided.\n";
chomp ($fileName);
print "$fileName does not exist" and die unless (-e $fileName);