control disposal 2

[zatch]

I have a form with eight textbox controls on it. I have the following procedure which should delete each of the textboxes. What it really does is delete every other textbox on the form. I click a button to call the "Clear_Tbox" procedure and what I'm left with are Textbox2, textbox4, textbox6, and textbox8. Anyone have an idea why this might be?

Private Sub Clear_Tbox()
Dim ctl As Control
For Each ctl In Me.Controls
If TypeOf ctl Is TextBox Then
ctl.Dispose()
End If
Next
End Sub

 

[ThatRickGuy]

The controls collection can be a bit finiky, try looping through the collection from top to bottom.

    Private Sub Clear_Tbox()
        Dim i as integer 
        For i = Me.Controls.count to 0
            If TypeOf Me.Controls(i) Is TextBox Then
                Me.Controls(i).Dispose()
            End If
        Next
    End Sub

-Rick

VB.Net Forum forum796 forum855 ASP.NET Forum
I believe in killer coding ninja monkeys.

 

[ThatRickGuy]

whoops, Me.Controls.count should be Me.Controls.count - 1

-Rick

VB.Net Forum forum796 forum855 ASP.NET Forum
I believe in killer coding ninja monkeys.

 

[zatch]

Thanks for your reply, Rick.

I changed your line: For i = Me.Controls.count - 1 to 0

to: For i = 0 to me.controls.count - 1

but it still did not work. Now I eventually get the error:

"Specified argument was out of the range of valid values." It is looking for controls which it can't find in the control collection it seems.

I'm sure I've done this before. Let me know if you have any other ideas.

Thanks again.

Zatch

 

[chrissie1]

what rick meant to say was this

Private Sub Clear_Tbox()
        Dim i as integer 
        For i = (Me.Controls.count-1) to 0 step -1
            If TypeOf Me.Controls(i) Is TextBox Then
                Me.Controls(i).Dispose()
            End If
        Next
    End Sub

wich means that it will loop through the collection backwards and will avoid the problem you had.



Christiaan Baes
Belgium

If you want to get an answer read this FAQ faq796-2540
There's no such thing as a winnable war - Sting

 

[ThatRickGuy]

Whoops, good catch Chrissie, I forget that dang Step -1 all the time.

-Rick

VB.Net Forum forum796 forum855 ASP.NET Forum
I believe in killer coding ninja monkeys.

 

[chrissie1]

Ah yes but you mean well. (is that the correct saying?)

Christiaan Baes
Belgium

If you want to get an answer read this FAQ faq796-2540
There's no such thing as a winnable war - Sting

 

[zatch]

Very nice. I've not stepped backward before. Thank you both.

Zatch

 

[chrissie1]

I've not stepped backward before

It's called moonwalking the MJ-way.

Christiaan Baes
Belgium

If you want to get an answer read this FAQ faq796-2540
There's no such thing as a winnable war - Sting