CommonDialog.Open Problem in VB5

tbohon · Apr 27, 2000

I'm writing a routine to open a file using VB5's common dialog box.  Only two types of files are allowed:  txt and dat and I want the routine (btnOpen.click) to loop until a valid file is selected. I've written something like the following for the click event: Private Sub Command1_Click() Dim LineIn as String, GoodFile As String, FileExt as String GoodFile = "N" Do Until GoodFile = "Y"   frmOpenFile.Show    ' this is the cdl form   FileName = frmOpenFile!CommonDialog1.FileName      FileExt = Ucase$(Right$(FileName, 3))   If FileExt = "EXE Or ... (other excluded types) Then     MsgBox "Invalid File Type"     frmOpenFile.Hide     FileName = ""     GoodFile = "N"   Else     GoodFile = "Y"   End If Loop Open FileName For Input As 1  ... Close 1 End Sub Routine seems to work the first time for a bad file (always works for a 'good' file) but the second time around for a bad one, it jumps out of the loop and tries to open something I don't want it to open OR, if I clear the file name in the common dialog box, it gives me a run-time error 'File or path not found'. I KNOW it's right in front of me ... but I'm just not seeing what's wrong. Any ideas/suggestions/fixes GRATEFULLY accepted. Thanks! Tom

MikeLacey · Apr 28, 2000

Have you looked at the Filter property? CommonDialog1.Filter = "All Files (*.*)¦*.*¦Text _    Files (*.txt)¦*.txt¦Batch Files (*.bat)¦*.bat" This would allow you to only select files with the extensions you want. (Your code looks fine - I was going to check it but comdlg32.ocx seems to be b(*&%$$%£d on my machine at the moment :-( I'm going to have to fix that one day) Mike <a href=mailto:Mike_Lacey@Cargill.Com>Mike_Lacey@Cargill.Com</a> <a href=

http://www.cargill.com/>

Cargill's Corporate Web Site</a> Please don't send me email questions without posting them as well. Post the question and send me a note saying "Have a look at so-and-so would you?" - that's fine.

tbohon · Apr 28, 2000

Yes - the filter is set to display .dat, .txt and all (*.*) files. I can't see that resetting it between attempts by the user to get a 'good' file would have any effect ... ???? So you're having the ole comdlg32.ocx problems too?  Glad I'm not the only one out here with that issue to face! Thanks for your note! Tom

Drone38 · Apr 29, 2000

Use this function if you won't give an ocx with your program.Many people don't like have many *.ocx on their PC Public Type OPENFILENAME         lStructSize As Long         hwndOwner As Long         hInstance As Long         lpstrFilter As String         lpstrCustomFilter As String         nMaxCustFilter As Long         nFilterIndex As Long         lpstrFile As String         nMaxFile As Long         lpstrFileTitle As String         nMaxFileTitle As Long         lpstrInitialDir As String         lpstrTitle As String         flags As Long         nFileOffset As Integer         nFileExtension As Integer         lpstrDefExt As String         lCustData As Long         lpfnHook As Long         lpTemplateName As String End Type ' Public Declare Function GetOpenFileName Lib "comdlg32.dll" Alias "GetOpenFileNameA" (pOpenfilename As OPENFILENAME) As Long Public Declare Function GetSaveFileName Lib "comdlg32.dll" Alias "GetSaveFileNameA" (pOpenfilename As OPENFILENAME) As Long ' ' Constant flags Public Const OFN_ALLOWMULTISELECT = &H200 Public Const OFN_CREATEPROMPT = &H2000 Public Const OFN_ENABLEHOOK = &H20 Public Const OFN_ENABLETEMPLATE = &H40 Public Const OFN_ENABLETEMPLATEHANDLE = &H80 Public Const OFN_EXPLORER = &H80000 Public Const OFN_EXTENSIONDIFFERENT = &H400 Public Const OFN_FILEMUSTEXIST = &H1000 Public Const OFN_HIDEREADONLY = &H4 Public Const OFN_LONGNAMES = &H200000 Public Const OFN_NOCHANGEDIR = &H8 Public Const OFN_NODEREFERENCELINKS = &H100000 Public Const OFN_NOLONGNAMES = &H40000 Public Const OFN_NONETWORKBUTTON = &H20000 Public Const OFN_NOREADONLYRETURN = &H8000 Public Const OFN_NOTESTFILECREATE = &H10000 Public Const OFN_NOVALIDATE = &H100 Public Const OFN_OVERWRITEPROMPT = &H2 Public Const OFN_PATHMUSTEXIST = &H800 Public Const OFN_READONLY = &H1 Public Const OFN_SHAREAWARE = &H4000 Public Const OFN_SHAREFALLTHROUGH = 2 Public Const OFN_SHARENOWARN = 1 Public Const OFN_SHAREWARN = 0 Public Const OFN_SHOWHELP = &H10 ' Global Dialogue As OPENFILENAME Public Function Dlg(Title As String, Filter As String, Hwnd As Long) As String Dim Fichier As String Dim Filtre As String Dim RetVal As Long Dialogue.lStructSize = Len(Dialogue) Dialogue.hwndOwner = Hwnd Dialogue.hInstance = App.hInstance Dialogue.lpstrFilter = Filter Dialogue.lpstrFile = Space(254) Dialogue.nMaxFile = 255 Dialogue.lpstrFileTitle = Space(254) Dialogue.nMaxFileTitle = 255 Dialogue.lpstrInitialDir = App.Path Dialogue.lpstrTitle = Title Dialogue.flags = 6148 ' RetVal = GetOpenFileName(Dialogue) If RetVal = 0 Then Dlg = "" Else Dlg = Dialogue.lpstrFile End If End Function Send me remark at <A HREF="mailto:drone38@mageos.com">drone38@mageos.com</A>

Tareq · May 1, 2000

CmDlgSnd.DialogTitle =

Tareq · May 1, 2000

CmDlgSnd.DialogTitle = "Please Select the Text File"                CmDlgSnd.Filter = "Text File (*.TXT) ¦ *.TXT"                CmDlgSnd.InitDir = App.Path                CmDlgSnd.ShowOpen

Jerryls · May 1, 2000

You don't need to see all files (*.*), just those you want. Like this: Filter = "Files (*.txt;*.dat)¦*.txt;*.dat" Also, If you make GoodFile a Boolean, then you can loop until GoodFile is TRUE. This will save your program from evaluating for "Y" each time. Like so: Dim GoodFile As Boolean Do Until GoodFile ' If FileExt ="txt" or FileExt="dat" Then GoodFile=True ' ' ' Loop

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

CommonDialog.Open Problem in VB5

tbohon

Programmer

MikeLacey

MIS

tbohon

Programmer

Drone38

Programmer

Tareq

Programmer

Tareq

Programmer

Jerryls

Technical User

Similar threads

Part and Inventory Search

Sponsor