Combine methods 1

[evergrean100]

I have 2 methods working in my class file that I am trying to convert into 1 method:

.....
public Preparestatement prep;
public int inserterOne(TheBean mybean)
{
    int status = 0;
    try {
    prep.connection.preparestatement("insert into person (city, state) values (?,?)");
    prep.setString(1,mybean.getCity());
    prep.setString(2,mybean.getState());
    prep.executeUpdate();
    }
    catch(Exception e) {
         e.printStacktrace();
    }
    return status;
 }
 
public int inserterTwo(TheBean mybean)
{
    int status = 0;
    try {
    prep.connection.preparestatement("insert into person (city, state) values (?,?)");
    prep.setString(1,mybean.getMainCity());
    prep.setString(2,mybean.getMainState());
    prep.executeUpdate();
    }
    catch(Exception e) {
         e.printStacktrace();
    }
    return status;
 }
 
public int hitter(TheBean mybean)
{
.....
inserterOne(mybean);
inserterTwo(mybean);    
...

Here is my attempt and not sure how to make this work?

public int inserterCombined(TheBean mybean)
{
    int status = 0;
    try {
    prep.connection.preparestatement("insert into person (city, state) values (?,?)");
    prep.setString(1,mybean.getCity());
    prep.setString(2,mybean.getState());
    prep.executeUpdate();

    prep.setString(1,mybean.getMainCity());
    prep.setString(2,mybean.getMainState());
    prep.executeUpdate();
    }
    catch(Exception e) {
         e.printStacktrace();
    }
    return status;
 }
 
....
public int hitter(TheBean mybean)
{
.....
inserterCombined(?? here);  //how would I know which part of the method to call here?

Please advise how I can get this to work. Thanks.

 

[Bong]

Why not have inserterOne call inserterTwo?

_________________
Bob Rashkin

 

[prosper]

The two methods are so similar that we can use one method instead.

I prefer flexible method.

public int inserterOne(String input1, String input2)
{
    int status = 0;
    try {
    prep.connection.preparestatement("insert into person (city, state) values (?,?)");
    prep.setString(1,mybean.input1);
    prep.setString(2,mybean.input2);
    prep.executeUpdate();
    }
    catch(Exception e) {
         e.printStacktrace();
    }
    return status;
 }

public int hitter(TheBean mybean)
{
 ...
 insertOne(mybean.getCity(),mybean.getState());
 insertOne(mybean.getMainCity(),mybean.getMainState());

 

[prosper]

public int hitter(TheBean mybean)
{
 ...
 inserterOne(mybean.getCity(),mybean.getState());
 inserterOne(mybean.getMainCity(),mybean.getMainState());

 

[prosper]

sorry for two times of mistakes

public int inserterOne(String input1, String input2)
{
    int status = 0;
    try {
    prep.connection.preparestatement("insert into person (city, state) values (?,?)");
    prep.setString(1,input1);
    prep.setString(2,input2);
    prep.executeUpdate();
    }
    catch(Exception e) {
         e.printStacktrace();
    }
    return status;
 }

public int hitter(TheBean mybean)
{
 ...
 inserterOne(mybean.getCity(),mybean.getState());
 inserterOne(mybean.getMainCity(),mybean.getMainState());
...
}