Code no longer works - after moved to .js file

[schedboy]

Hi all,

I had this code working:



bannerQuotes = new Array("img/border_bot_left.gif","img/border_top_left.gif","img/border_top_right.gif","img/border_top_left.gif");

startAt = 0;
totalElements = bannerQuotes.length;


function rotate()
{
if(document.images)
{
startAt++;
if(startAt==totalElements)
{ startAt=0;}

document.adBanner.src=bannerQuotes[startAt];
setTimeout("rotate()",3*1000);
}
}



Fine if included in the head tags of my HTML doc, and calling rotate() from the body onload event.

However, now I've cut it out and placed it externally - it no longer works...

I've got:

<script src="/jscript/amsJScod.js" language="Javascript" type="text/javascript">
</script>

In my header but am having no luck

Thanks

Sched

 

[BabyJeffy]

Just in case you haven't, make sure that you remove the <script>...</script> tags from the javascript file (amsJScod.js).

Cheers,
Jeff

[tt]Jeff's Page @ Code Couch

http://www.codecouch.com/jeff/blog/

http://www.coedit.co.uk/

[/tt]

What is Javascript? FAQ216-6094

 

[schedboy]

Hi BabJeff,

The only thing in the .js file is what you see in my first post.

any other ideas?????

Thanks

Sched

 

[Diancecht]

What error do you get?

Cheers,
Dian

 

[schedboy]

Hi all,

Cheers for your replies.
I have fixed the problem, it was with the path of the .js file:

<script src="/jscript/amsJScod.js" language="Javascript" type="text/javascript">
</script>

Once I removed the first / from the path, it worked fine! I guess I'll have to put it back when I upload to the server?????

Thanks

Sched

 

[Diancecht]

If you put it, the script will reference an absolute path. If not, the path will be relative, and I think that's what you're looking for, so I'd not change it.

Cheers,
Dian