checking if name exists

[calv1n]

I added this to check if username exists when adding administrator on my site:

                $result = mysql_query("SELECT username from admin where username='$username'");
                list($usernametocheck) = mysql_fetch_row($result);

                if (!$usernametocheck) {
                        //good!
                } else {
                        Message("Username Exists", "The username you have chosen already exists.", "");
                }

Okay so I added that to the 'edit admin' function and I get the message 'The username you have chosen already exists.'. I think I know why, but I can;t fix it.

Any help will be appreciated.

-CALV1N

 

[Olavxxx]

Try this code:

mysql_connect($server, $db_user, $db_pass) or die ("CONNECT Error");


    // gather link
    $result=mysql_db_query($database, "SELECT username FROM `admin` WHERE `username` = '{$username}'") or die("Database SELECT Error");
    $c_totals  = mysql_num_rows($result);

    if ($c_totals > 0)  {
	Message("Username Exists", "The username you have chosen already exists.", "");
	    /*
	      while ($row = mysql_fetch_array($result)) {
	        } // end while
	    */
      } // end if $c_totals > 0
    else {
    	echo "\n\n\t<!-- Added: {$username} -->\n\n";
      }

Ps. I wrote it in textpad and havent tried it..
It's also worth mentioning you should secure the variables..

eg.. Look at mysql injection (best practice, safe queries).
Use sprintf, strip_tags, trim, etc. on the variables!

Olav Alexander Mjelde

http://www.volvo-power.net

Admin & Webmaster