Checking checkbox value against array, show element 2

[travisbrown]

It seems to me that this should work. I'm not getting an error, and values seem to be passing through, but still nothing happens.

Can someone see something obviously wrong?

When a checkbox is clicked, the function checks the value against an array. If true, it should display a table row.

<input type="checkbox" name="arr_groups_id" value="31" onclick="checkGroupForEList(this.value);" />

        <tr id="row_elist" style="display:none;">
          <td>...</td>
        <td>...</td>
        </tr>

function checkGroupForEList(group_id) {
			if ( checkArray(group_id,'30,31,38') ) 
			document.getElementById('row_elist').style.display = '';
		}

function checkArray(matchVal,theArray)
{
   var match=false;
   var myArray= new Array (theArray)
   for (i=0;i<myArray.length;i++)
   {
      if (myArray[i]==matchVal)
      {
         match=true;
      }
   }
   return match;
}

 

[BillyRayPreachersSon]

If you're displaying a table row, you should probably change this:

.style.display = '';

to this:

.style.display = 'table-row';

Hope this helps,
Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[BillyRayPreachersSon]

Also your array creating is flawed. You have only one element with a string of "30,31,38". Change this line:

var myArray= new Array (theArray)

to this:

var myArray = theArray.split(',');

Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[BillyRayPreachersSon]

You can also optimise it further by changing this:

match=true;

to this:

match = true;
break;

as there is no point in continuing the iteration once you've found a positive match.

Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[monksnake]

I'd be careful about using display="table-row", at least for a while, it's not supported in IE6, though it is semantically correct.

Here's a reference for that:

http://jszen.blogspot.com/2004_07_01_archive.html

For now, I'd just use display="block", just so it works cross-browser.

<.

 

[travisbrown]

Thanks all.

I didn't realize I wasbreaking the array; I guess I made it a string. I was using the function based on another suggestion (

http://tek-tips.com/viewthread.cfm?qid=1337090&page=2),

but that was integers not passed in as a variable.