changing lines with sed 2

[stanhubble]

problem .... file with lines in the form of :

TAG_NAME="value1 value2 value3"

and i want to replace the line with:

TAG_NAME="value1 value2 value4 value5 value6"

(note the spaces and the quotes)

i can parse things out such that i have and var $ENV1 with
value1 value2 value3

in it and var $ENV2 with
value1 value2 value4 value5 value6
in it

I have tried a number of variants with sed that don't seem to work

sed -i 's/${ENV1}/${ENV2}/g' $CFGFILE
sed -i 's/'${ENV1}'/'${ENV2}'/g' $CFGFILE

i have also tried the /c change command
and i think its the spaces that are screwing me up.
i and not getting any errors, just the change is not happening.
is sed the right tool to be trying this with?

 

[feherke]

Hi

Also tried this ?

sed -i [red]"[/red]s/${ENV1}/${ENV2}/g[red]"[/red] $CFGFILE

Feherke.

http://rootshell.be/~feherke/

 

[stanhubble]

yes that actually comes back with an error

sed: -e expression #1, char 20: unterminated `s' command

 

[feherke]

Hi

Are you sure ENV1 and ENV2's values does not include the double quotes ( " ) ?

Feherke.

http://rootshell.be/~feherke/

 

[PHV]

What are the REAL values of ENV1 and ENV2 ?
No / inside ?

Hope This Helps, PH.
FAQ219-2884
FAQ181-2886

 

[stanhubble]

FW_SERVICES_EXT_TCP="5801 5901 ssh"
 
-> ENV1=5801 5901 ssh

FW_SERVICES_EXT_TCP="5801 5901 buyguide ftp homedyn http prismmas prismsc prismsh prismxs prismxw ssh xdmcp xscomm"

-> ENV2=5801 5901 buyguide ftp homedyn http prismmas prismsc prismsh prismxs prismxw ssh xdmcp xscomm

 

[PHV]

How do you assign ENV1 and ENV2 in your script ?

Hope This Helps, PH.
FAQ219-2884
FAQ181-2886

 

[stanhubble]

note $SID is set elsewhere and may be null

#################################################################
# Poke some holes in the firewall for database socket connections
CFGFILE=/etc/sysconfig/SuSEfirewall2
ORGPATTERN=`cat $CFGFILE | grep "^FW_SERVICES_EXT_TCP="` 
EXISTINGHOLES=`cat $CFGFILE | grep "^FW_SERVICES_EXT_TCP=" | cut -d\" -f2`
rm -f /tmp/holes.$$
#echo "Existing Holes = " $EXISTINGHOLES
for j in $EXISTINGHOLES
do
    echo $j >> /tmp/holes.$$
done
for i in prismmas prismsc prismsh prismxs prismxw xscomm buyguide homedyn homestat
do
    echo $i$SID >> /tmp/holes.$$
done
#echo "New Holes = " `cat /tmp/holes.$$`
NEWHOLES=`cat /tmp/holes.$$ | sort -u`
rm -f /tmp/holes.$$
sed -i 's/'${EXISTINGHOLES}'/'${NEWHOLES}'/g' $CFGFILE
#################################################################

 

[PHV]

Replace this:
NEWHOLES=`cat /tmp/holes.$$ | sort -u`

with this:
NEWHOLES=`sort -u /tmp/holes.$$ | tr '\n' ' '`

Hope This Helps, PH.
FAQ219-2884
FAQ181-2886

 

[stanhubble]

thx guys that now worked with the

NEWHOLES=`sort -u /tmp/holes.$$ | tr '\n' ' '`
and
sed -i "s/${ENV1}/${ENV2}/g" $CFGFILE