Changing an Email Link

[jon24422531]

Hi guys

Here is a very good reason to stop cutting and pasting code with out knowing how it works. Sadly I've never really understood JavaScript....

I have an internal website that Emails a User when their helpdesk question has been updated and there is a link:

http://Intranet/worklogOpenDetail.asp?id=11274

This opens in a frame thanks to the following code in both the index page:

<SCRIPT LANGUAGE="JavaScript">
<!--
defaultsubpage="UserStart.asp";
if (location.search) {subpage=location.search.substring(1)}
else {subpage=defaultsubpage}

if (subpage.indexOf('&&&')>=0) {
prefix=subpage.substring(0,subpage.indexOf('&&&'))+"://";
suffix=subpage.substring(subpage.indexOf('&&&')+3,subpage.length);
subpage=prefix+suffix;
}
// -->
</SCRIPT>
</HEAD>


<SCRIPT>
document.write('<FRAMESET ROWS="10,*,0" BORDER="0" FRAMEBORDER=No FRAMESPACING="0">');
document.write('<FRAME NAME = "HEAD" SRC="Header.html"  BORDER="0" FRAMEBORDER=No SCROLLING="NO" NORESIZE >');
document.write('<FRAMESET COLS="200,*" BORDER="0" FRAMEBORDER=No FRAMESPACING="0">');
document.write('<FRAME NAME = "NAV" SRC="Navigate.asp" BORDER="0" FRAMEBORDER=No SCROLLING="NO" NORESIZE >');
document.write('<FRAME NAME = "CENTER" SRC="'+subpage+'" BORDER="0" FRAMEBORDER=No SCROLLING="AUTO">');
document.write('</FRAMESET>');

</SCRIPT>

and also in the opening worklogOpenDetail.asp page:

<script>
function detect()
{
framesetpage="Index.html";
thispage=window.location.href;
if (thispage.indexOf('://')<0) {thispage="://"+thispage;};
prefix=thispage.substring(0,thispage.lastIndexOf('://'));
suffix=thispage.substring(thispage.lastIndexOf('://')+3,thispage.length);
// alert('the subpage is:['+prefix+']['+suffix+']');
if (parent.location.href==window.location.href) {parent.location.href=framesetpage+"?"+prefix+"&&&"+suffix};
}
</script>

If I change the link (generated by SQL Mail)

http://Intranet/WorkLogs/worklogOpenDetail.asp?id=11267

(note that there is an additional folder)
It no longer opens in the frame, but as a new page or tab. What do I need to alter in the JavaScript to get it to point to the new folder and open in the frame as before?

Coding is like Shakespeare; I can read it, even appreciate & understand it, but I could never write it.

Jonathan

http://www.telecom-stuff.com

 

[vicvirk]

as a technical user, can you explain to me how on earth you expect anyone outside of your network to click those links you provided?

--------
GOOGLE is a great resource to find answers to questions like "how do i..."

If you don't know exaclty what you want to do or what to search on, try Google Suggest:

http://www.google.com/webhp?complete=1&hl=en

--------
I have recently been semi-converted to ensuring all my code (well most of it) works in both javascript and non-javasc

 

[jon24422531]

Hi vicverk

That is just the point, only people within our network (or on the VPN) can access our Intranet. I don't want you to click them, I was just showing what did work, but now will not after I added another folder above the

http://www root.

I just need to add the "WorkLogs" folder in the JavaScript but I don't know where.


Jonathan

http://www.telecom-stuff.com