Can't seem to clear timeout?

[1DMF]

Hi, I have some rotating banners, I rotate them via timeouts...

// add banner rotate timeout helper
function addBannerRotate(page,pos,ord,timeout)
{    
    var rot = "rotateBanner('"+page+"','"+pos+"',"+ord+")";                       
    BanRotate[pos][ord] = setTimeout(rot,(timeout * 1000));    
}

So I have an object BanRotate, that stores the desired timeouts, this work fine.

However, I want to load a new page via AJAX, clear the old timeouts and assign new ones.

Getting the page works, creating new timeouts is working, but I seem unable to clear the old timeouts and they seem to still run.

I have this code

    // clear any timeouts
    $(BanRotate).each(function(i,val){
        $(val).each(function(i2,val2){
            clearTimeout(val2);          
        });        
    });

But it isn't' clearing the timeouts?

Any ideas why?

Thanks,
1DMF



"In complete darkness we are all the same, it is only our knowledge and wisdom that separates us, don't let your eyes deceive you."

"If a shortcut was meant to be easy, it wouldn't be a shortcut, it would be the way!"
Free Electronic Dance Music

 

[1DMF]

OK, solved it.

I changed the JQuery iterator and it's working...

    // clear any timeouts
    $.each(BanRotate,function(i,val){
        $.each(val,function(i2,val2){
            clearTimeout(val2);          
        });        
    });

"In complete darkness we are all the same, it is only our knowledge and wisdom that separates us, don't let your eyes deceive you."

"If a shortcut was meant to be easy, it wouldn't be a shortcut, it would be the way!"
Free Electronic Dance Music

 

[jpadie]

yup. the first iterates over a jquery collection. the second is a helper function for iterating arrays.

they are confusingly close in name

 

[1DMF]

yeah, I find that my brain goes into auto pilot when coding JQuery, and sometimes codes the wrong iterator without thinking.

I then stare at the code thinking why won't you work, it looks fine!

"In complete darkness we are all the same, it is only our knowledge and wisdom that separates us, don't let your eyes deceive you."

"If a shortcut was meant to be easy, it wouldn't be a shortcut, it would be the way!"
Free Electronic Dance Music

 

[jpadie]

if there are some frequent boo-boos then consider writing some abstraction functions that work more like your brain wants them to.

i do that with php a lot. things like isArray() rather than is_array() etc.

 

[1DMF]

I do have a few helper methods I use, but I think on this occasion, I just needed to use the correct iterator!

"In complete darkness we are all the same, it is only our knowledge and wisdom that separates us, don't let your eyes deceive you."

"If a shortcut was meant to be easy, it wouldn't be a shortcut, it would be the way!"
Free Electronic Dance Music