can't get function to fire 2

[simon551]

Hi,

I validated my html at w3 validator but I can't get this script to fire:

newTicket.js

function getname(trav){
	var trav=document.getElementById('traveler').value;
	if (trav != "Non-Employee"){
			document.getElementById("traveler_name").type="text";
			setTimeout('document.getElementById("traveler_name").focus()',100);
	}
	}
//this function calls the other on the changing of name
function writeName(){
	document.getElementById('traveler').onchange=getname;
}

I call it here:

<script src="../Scripts/newTicket.js" type="text/javascript"></script>
<script type="text/javascript">window.onload=writeName();</script>

and this is my form field:

<select name="traveler" id="traveler">
        <option value="null">--please select--</option>
        <option value="Non-Employee">Non-Employee</option>
        <?php
do {  
?>
        <option value="<?php echo $row_rsEmployees['EmpID']?>"><?php echo $row_rsEmployees['Employee']?></option>
        <?php
} while ($row_rsEmployees = mysql_fetch_assoc($rsEmployees));
  $rows = mysql_num_rows($rsEmployees);
  if($rows > 0) {
      mysql_data_seek($rsEmployees, 0);
	  $row_rsEmployees = mysql_fetch_assoc($rsEmployees);
  }
?>
      </select>

 

[BillyRayPreachersSon]

When you say "can't get it to fire", do you mean it isn't called at all, or it doesn't do what you expect?

Some thigs to confirm:

1) You have a single element with an ID of "traveler_name" on your page (your code refers to this, but it's not in the HTML you posted)

2) Your fuction is being called at all (put an alert right at the top of it).

Hope this helps,
Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[feherke]

Hi

There is a difference between

[gray]// assign the return value of the writeName() function to the onload[/gray]
window.onload=writeName();

[gray]// assign the writeName() function to the onload[/gray]
window.onload=writeName;

Feherke.

http://rootshell.be/~feherke/

 

[simon551]

Thank you both! Both tips were very helpful. I got it to run.