can someone tell me why this line does not work in Mozilla browsers?

[mcmcom89]

function displayHTML(form) {
var inf = form.txtStory.value;
var tmp = inf.replace(new RegExp(/\r\n/g),"<br>");
win = window.open(", ", 'popup', 'toolbar = no, status = no, height=500 width=410 resizable=yes, scrollbars=yes');
win.document.write("<font face='arial' size=2><b>Preview your message:</b><br><br>" + tmp + "<br><br><a href='#' onclick='window.close()'><img border=0 src='images/close_button.gif'></a></font>");
}

its writing out but the Replace function does not replace the newline breaks with <BR>

thanks

 

[cLFlaVA]

there are a few things wrong with this.

1) you should always use references in this manner:

var inf = form.elements['txtStory'].value;

but i'm sure you will ignore that advice.

2) your regex needs escaped backslashes, because backslashes in themselves are escape characters. try this:

var tmp = inf.replace(new RegExp(/[red]\[/red]\r[red]\[/red]\n/g),"<br>");

3) you need commas in between each window characteristic, like this:

'toolbar = no, status = no, height=500[red],[/red] width=410[red],[/red] resizable=yes, scrollbars=yes'

try all that. then let us know how it works.

*cLFlaVA
----------------------------
[tt]I already made like infinity of those at scout camp...[/tt]
[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[mcmcom89]

thanks i made the comma changes and changed the line to read form.elements['myelement'] as you said

but the regex still does not work.

if i use escaped chars (\\r\\n) it does not work for either IE or Mozilla,

if i use my original line it works in IE but not Mozilla

any ideas?

thanks

 

[cLFlaVA]

this regular expression worked for me in both ie and ff:

var re = /\r\n|\r|\n/g;

*cLFlaVA
----------------------------
[tt]I already made like infinity of those at scout camp...[/tt]
[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[kaht]

I'm not sure you can pass a regexp as a valid parameter to the RegExp constructor. It usually accepts 2 strings - first one is a string representation of the regexp (excluding the 2 /'s) and the 2nd is a string representation of the regular expression flags (g, i, and gi). Additionally, you do not have to escape your escape characters if you are not defining the regexp using the RegExp function (or in other words, declaring it as a string).

Either of these should work, but do not mix the 2:

var tmp = inf.replace(new RegExp("\\r\\n", "g"), "<br>");
-or-
var tmp = inf.replace(/\r\n/g, "<br>");

I prefer the 2nd method, but that's just me. I only use the fist method if I have to build the regexp dynamically - hence the need for a string.

-kaht

How much you wanna make a bet I can throw a football over them mountains?

 

[kaht]

Oh, cory also makes a good point, I'm pretty sure that FF and IE interpret line breaks differently. I believe BabyJeffy did a test on this in another thread a few weeks ago. I think one interpreted a line break as \r\n and another interpreted it as just \n. (or some combination thereof)

-kaht

How much you wanna make a bet I can throw a football over them mountains?

 

[BillyRayPreachersSon]

Removing the font tags would also be a good idea. Use CSS instead.

Hope this helps,
Dan



[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[mcmcom89]

/\r\n|\r|\n/g;

that works for me too!

thanks guys! and i will remove the font tags and use css

lates.