can a loop be used here? 1

[jamert]

Hi below i'm comparing variable to request.Form variables of the same name, then if they do not match a parameter is created for an insert procedure. Was wondering how this can be cleaner, can a for loop be used? Thanks

if (aller_medName0 != Request.Form["aller_medName0"].ToString()) { cmd.Parameters.Add("@aller_medName0", SqlDbType.NVarChar).Value = Request.Form["lname"].ToString(); }

if (aller_medName1 != Request.Form["aller_medName1"].ToString()) { cmd.Parameters.Add("@aller_medName1", SqlDbType.NVarChar).Value = Request.Form["lname"].ToString(); }

if (aller_medName2 != Request.Form["aller_medName2"].ToString()) { cmd.Parameters.Add("@aller_medName2", SqlDbType.NVarChar).Value = Request.Form["lname"].ToString(); }

if (aller_medName3 != Request.Form["aller_medName3"].ToString()) { cmd.Parameters.Add("@aller_medName3", SqlDbType.NVarChar).Value = Request.Form["lname"].ToString(); }

if (aller_medName4 != Request.Form["aller_medName4"].ToString()) { cmd.Parameters.Add("@aller_medName4", SqlDbType.NVarChar).Value = Request.Form["lname"].ToString(); }

if (aller_medName5 != Request.Form["aller_medName5"].ToString()) { cmd.Parameters.Add("@aller_medName5", SqlDbType.NVarChar).Value = Request.Form["lname"].ToString(); }

if (aller_medName6 != Request.Form["aller_medName6"].ToString()) { cmd.Parameters.Add("@aller_medName6", SqlDbType.NVarChar).Value = Request.Form["lname"].ToString(); }

if (aller_medName7 != Request.Form["aller_medName7"].ToString()) { cmd.Parameters.Add("@aller_medName7", SqlDbType.NVarChar).Value = Request.Form["lname"].ToString(); }

if (aller_medName8 != Request.Form["aller_medName8"].ToString()) { cmd.Parameters.Add("@aller_medName8", SqlDbType.NVarChar).Value = Request.Form["lname"].ToString(); }

if (aller_medName9 != Request.Form["aller_medName9"].ToString()) { cmd.Parameters.Add("@aller_medName9", SqlDbType.NVarChar).Value = Request.Form["lname"].ToString(); }

if (aller_medName10 != Request.Form["aller_medName10"].ToString()) { cmd.Parameters.Add("@aller_medName10", SqlDbType.NVarChar).Value = equest.Form["lname"].ToString(); }

 

[jamert]

sry i just realized what i posted was garbage, here is what i really have:

if (aller_medName0 != Request.Form["aller_medName0"].ToString()) { cmd.Parameters.Add("@aller_medName0", SqlDbType.NVarChar).Value = MdaBlowfish.encMCformTemp(Request.Form["aller_medName0"].ToString()); }

if (aller_medName1 != Request.Form["aller_medName1"].ToString()) { cmd.Parameters.Add("@aller_medName1", SqlDbType.NVarChar).Value = MdaBlowfish.encMCformTemp(Request.Form["aller_medName1"].ToString()); }

if (aller_medName2 != Request.Form["aller_medName2"].ToString()) { cmd.Parameters.Add("@aller_medName2", SqlDbType.NVarChar).Value = MdaBlowfish.encMCformTemp(Request.Form["aller_medName2"].ToString()); }

if (aller_medName3 != Request.Form["aller_medName3"].ToString()) { cmd.Parameters.Add("@aller_medName3", SqlDbType.NVarChar).Value = MdaBlowfish.encMCformTemp(Request.Form["aller_medName3"].ToString()); }

if (aller_medName4 != Request.Form["aller_medName4"].ToString()) { cmd.Parameters.Add("@aller_medName4", SqlDbType.NVarChar).Value = MdaBlowfish.encMCformTemp(Request.Form["aller_medName4"].ToString()); }

if (aller_medName5 != Request.Form["aller_medName5"].ToString()) { cmd.Parameters.Add("@aller_medName5", SqlDbType.NVarChar).Value = MdaBlowfish.encMCformTemp(Request.Form["aller_medName5"].ToString()); }

if (aller_medName6 != Request.Form["aller_medName6"].ToString()) { cmd.Parameters.Add("@aller_medName6", SqlDbType.NVarChar).Value = MdaBlowfish.encMCformTemp(Request.Form["aller_medName6"].ToString()); }

if (aller_medName7 != Request.Form["aller_medName7"].ToString()) { cmd.Parameters.Add("@aller_medName7", SqlDbType.NVarChar).Value = MdaBlowfish.encMCformTemp(Request.Form["aller_medName7"].ToString()); }

if (aller_medName8 != Request.Form["aller_medName8"].ToString()) { cmd.Parameters.Add("@aller_medName8", SqlDbType.NVarChar).Value = MdaBlowfish.encMCformTemp(Request.Form["aller_medName8"].ToString()); }

if (aller_medName9 != Request.Form["aller_medName9"].ToString()) { cmd.Parameters.Add("@aller_medName9", SqlDbType.NVarChar).Value = MdaBlowfish.encMCformTemp(Request.Form["aller_medName9"].ToString()); }

if (aller_medName10 != Request.Form["aller_medName10"].ToString()) { cmd.Parameters.Add("@aller_medName10", SqlDbType.NVarChar).Value = MdaBlowfish.encMCformTemp(Request.Form["aller_medName10"].ToString()); }

 

[jmeckley]

without knowning the context of situation it can only be refactored so much. however, I don't think the problem starts with the code. it starts with the database.
fields named aller_medName[X] is usually a sign of a de-normalized db. this will only cause more problems later on in development.

however to assist this current issue you could do this

string[] medNames = new string[] { 
   aller_medName0, 
   aller_medName1,
    ...  
};

string baseId = "aller_medName";
for(int 1 = 0; i <= medNames.Length; i++)
{
   string controlId = string.Format("{0}{1}", baseId, i);
   string value = Form[controlId] as string;
   if(medNames[i] != value)
   {
       string parameterName = string.Format("@{0}{1}", baseId, i);
       SqlParameter parameter = new SqlParameter(parmeterName, SqlDbType.NVarChar);
       parameter.Value = value;
       cmd.Parameters.Add(parameter); 
   }
}

Jason Meckley
Programmer
Specialty Bakers, Inc.