C# Help with division

[jgd1234567]

Hi, i haven't been programming in c# for long and was wondering how i could rewrite the code below to be alot nice:

int width = 100;
int height = 130;
float ratio = (float)image.Width / (float)image.Height;

if ((float)width / (float)height > ratio)
  width = (int)Math.Round((float)height * (float)ratio);
else
  height = (int)Math.Round((float)width / (float)ratio);

I haven't quite mastered the art of casting. Appreciate your help. Thanks

 

[ca8msm]

how i could rewrite the code below to be alot nice

And how do you define "nice"?


-------------------------------------------------------

Mark,
[URL unfurl="true"]http://aspnetlibrary.com[/url]
[URL unfurl="true"]http://mdssolutions.co.uk[/url] - Delivering professional ASP.NET solutions
[URL unfurl="true"]http://weblogs.asp.net/marksmith[/url]

 

[NeilTrain]

theres not much you can do to make it "nicer?", except remove a few uneccesary casts

float width = 100;
float height = 130;
float ratio = (float)image.Width / (float)image.Height;

if (width / height > ratio)
  width = Math.Round(height * ratio);
else
  height = Math.Round(width / ratio);

but then I'm assuming you're going to use these for creating a new image, in which case, you would cast them one more time:

Bitmap newImage = new Bitmap((int)height,(int)width);

But that's still less casting overall. Remember, casting doesnt only make for ugly code, its slow. It should be minimized as much as possible.

 

[jgd1234567]

Hi cheers for your help NeilTrain. I am coming from a php background. I like c# and the compiler can be great but something as simple as division often become abit of a mess.