Bad object reference

[pahiker]

I have a script trying to change the height in an object tag. It is working in most browsers but a few, like IE7 are tossing an error:

Here is the script, the line with the obj.height is what is causing the problem. I tried changing the setting of obj to getElementByTagName and it works (no error message) but the object on the main page doesn't resize in any browser.

Here is the script:

function loaded() {
	var body = document.body,
		html = document.documentElement;
	var s = Math.max(body.offsetHeight, html.scrollHeight, html.offsetHeight);
	var obj = document.getElementById("objContent");
	obj.height = s + 10;
}

Here is a snippet of the main page with the div containing the object:

<div id="divContent" class="left">
	<object id="objContent" data="Home/Prayer.html" width="100%" height="100%" type="text/html"></object>
</div>

Let all bear in mind that a society is judged not so much by the standards attained by its more affluent and privileged members as by the quality of life which it is able to assure for its weakest members.

 

[ChrisHirst]

getElementByTagName is actually getElementsByTagName('tag') and createa an arrary of ALL the <tag> elements in the document.

Where are you calling the script from?

Chris.

Indifference will be the downfall of mankind, but who cares?
Time flies like an arrow, however, fruit flies like a banana.
Webmaster Forum

 

[ChrisHirst]

Better still; give us a URI so we can go look for ourselves.

Chris.

Indifference will be the downfall of mankind, but who cares?
Time flies like an arrow, however, fruit flies like a banana.
Webmaster Forum

 

[pahiker]

http://www.pahiker.com/FTFdev/index.html

I thought that getElementById returned a single occurrence by Id, which is what I was trying for.

Let all bear in mind that a society is judged not so much by the standards attained by its more affluent and privileged members as by the quality of life which it is able to assure for its weakest members.

 

[ChrisHirst]

I thought that getElementById returned a single occurrence by Id, which is what I was trying for.

It does


Firefox error console throws up this.

Timestamp: 23/09/2012 00:40:16
Warning: SyntaxError: test for equality (==) mistyped as assignment (=)?
Source File:

http://www.pahiker.com/FTFdev/js/setButton.js

Line: 46, Column: 21
Source Code:
while(e=allTags[i++]){

------------------------^

IE9 Dev tools throws
SCRIPT5007: Unable to get value of the property 'type': object is null or undefined
reSize.js, line 6 character 2
which is this line

alert(obj.type);

And there is no 'type' property, there is a typeof property.



Chris.

Indifference will be the downfall of mankind, but who cares?
Time flies like an arrow, however, fruit flies like a banana.
Webmaster Forum

 

[pahiker]

The = is correct, it is not a comparison, but setting a value. This works.

I tried different properties on the alert, even just obj, nothing works. Obj returns null, for some reason it's not losing the object.

Let all bear in mind that a society is judged not so much by the standards attained by its more affluent and privileged members as by the quality of life which it is able to assure for its weakest members.

 

[pahiker]

This is now resolved.

Let all bear in mind that a society is judged not so much by the standards attained by its more affluent and privileged members as by the quality of life which it is able to assure for its weakest members.

 

[ChrisHirst]

while(e=allTags[i++]){ Is NOT an assignment it is a comparison

Chris.

Indifference will be the downfall of mankind, but who cares?
Time flies like an arrow, however, fruit flies like a banana.
Webmaster Forum

 

[pahiker]

The code works, test it. allTags contains the tag name array, the e=allTags[i++] assigns the appropriate element to e, when at the end e contains zero. The while statements fails when e=0 and falls through. Pop it into a program, it works. This changes the eight large buttons (including their text) when one of the top three buttons is click. That works.

	var allTags = document.getElementsByTagName("*");
	var i=0, l=0;
	var e;
	while(e=allTags[i++]){
		if(e.id.substring(0,4) == "link") {
			if (l < ary.length) {
				e.className = btn;
				e.innerHTML = ary[l][0];
				e.data = ary[l][1];
				e.style.visibility = 'visible';
				l++;
			}
			else {
				e.style.visibility = 'hidden';
			}
		}

Let all bear in mind that a society is judged not so much by the standards attained by its more affluent and privileged members as by the quality of life which it is able to assure for its weakest members.

 

[feherke]

Hi

while(e=allTags[i++]){ Is NOT an assignment it is a comparison

The [tt]while[/tt] needs a value to test for truthness. The assignment results in a value, so it is perfectly usable there.

It is practically the same as :

[b]while[/b] [teal]([/teal][highlight][teal]([/teal][/highlight]e[teal]=[/teal]allTags[teal][[/teal]i[teal]++][/teal][highlight][teal])[/teal][teal]!==[/teal]undefined[/highlight][teal])[/teal] [teal]{[/teal]

when at the end e contains zero

You probably mean [tt]undefined[/tt].

Feherke.
[link feherke.github.com/]

http://feherke.github.com/

[/url]

 

[pahiker]

You probably mean undefined.

Could be, I was going back to my experience with C++, Perl, and Java, where 0=false and <>0 = true.

Regardless, and the overall page code has change since this thread started, IE still doesn't behave with the object code. I'm thinking there is no way to get it to work, and I need to go back to iFrame.

Let all bear in mind that a society is judged not so much by the standards attained by its more affluent and privileged members as by the quality of life which it is able to assure for its weakest members.