Can anyone tell me what is wrong with this program?<br><br>#include <iostream.h><br>int main()<br>{<br> int count[]= {0};<br> int ch, x;<br> float num , total, average;<br><br> x =0;<br> total = 0.0;<br><br> for (count[x] =0; count[x] < ch; count[x]++)<br> {<br>cout << "Enter a number:";<br>cin>> count[ch];<br>total = total + count[ch];<br> }<br> average = total / 6;<br> cout<<average<<endl;<br><br> return 0;<br>}
Tek-Tips is the largest IT community on the Internet today!
Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!
-
Congratulations strongm on being selected by the Tek-Tips community for having the most helpful posts in the forums last week. Way to Go!
array
- Thread starter joebeach
- Start date
<br>Try this<br><br>#define MAXNUMS 6 <br>// set MAXNUMS to whatever you want<br>include <iostream.h><br>int main()<br>{<br> int count[MAXNUMS]= {0};// sets all array elements to 0<br> float total = 0.0;<br> float average = 0.0;<br><br> for (int x = 0; x < MAXNUMS; x++)// 0 to MAXNUMS - 1<br> {<br> cout << "Enter a number: ";<br> cin >> count[x];<br> total += count[x];// same as total = total + count[x];<br> }<br> if(MAXNUMS != 0)<br> average = (total / MAXNUMS);<br> cout << average << endl;<br><br> return 0;<br>}
Like TomMcL2 said -- you need to allocate storage for the array. Declaring it as:<br><FONT FACE=monospace><br> int count[]= {0};<br></font><br>doesn't reserve any memory for the contents of count[]. IOW, you reserved space for 0 elements. It's good practice to do like TomMcL2 did, and use a constant for array bounds. That way, if you ever need to change the array size, there's only one place you need to go to to make the change. Otherwise, you'd have to change where the array was declared, then search through your code for every place where the array indexer might go out of bounds, etc. etc. (IOW, a real pain).<br><br>Chip H.<br><br> <br><br>
Actually, int count[] = {0} reserves 1 element, the 0 element. <br><br>As stated by those above, allocating space for your array is the key issue. Using a constant is good for making the array a static size. Previous suggestions illustrate how to do this very well. Judging from the original code, you need a dynamic solution.<br><br>To retain the dynamics you need, explore malloc and realloc and their relationship to your array. Also look at the interface to existing dynamic array classes. The main point of interest being their GrowBy property. <br><br>Both malloc and realloc are ANSI so you should have them available reguardless of platform.<br><br>One last thing you need to remember, you'll need to free the array when done or you'll end up having to reboot somewhere down the line. <p>Wil Mead<br><a href=mailto:wmead@optonline.net>wmead@optonline.net</a><br><a href= > </a><br>
- Status
Similar threads
- Locked
- Question