Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

  • Congratulations Mike Lewis on being selected by the Tek-Tips community for having the most helpful posts in the forums last week. Way to Go!

Another site review

Status
Not open for further replies.

philote

MIS
Oct 2, 2003
861
US
I'm pretty decent with the coding but always struggle to make things look nice. Please check out and tell me what's good and what can be improved. There's pretty much no content right now, though that is coming soon. I tried to make this site as simple and small as possible and hope there are few compatibility issues. Please tell me what browser you view it in and what OS you're running. I've already tested in IE6 and Mozilla on WinXP and all seems well.

Thanks!

Kevin
A+, Network+, MCP
 
works fine on ie6 here -- i think it looks ok

<Signature>
Sometimes the Answer You Are LOOKING for can be FOUND BY SEARCHING THE FAQ'S @&%$*#!!!
</Signature>
 
I'm not crazy about the color scheme, but I guess that's just personal preference. Other than that, looks good!

Also, the code looks real clean. I'm impressed that you did it all with CSS & DIV tags. No tables. I still have a tough time getting CSS to fully replace tables. Did you hand code it, or did you use a wysiwyg like Dreamweaver?

Good job.
-Ron

-We all play from the same deck of cards, it's how we play the hand we are dealt which makes us who we are.
 
Thanks Ron. I can't decide if I like the color scheme now or not. I remember liking it when I started on the site but I've been looking at it way too long now.

I've coded the whole thing by hand, a tedious process but I've learned a ton.

Kevin
A+, Network+, MCP
 
philote, hey just looked at the site under IE6/1024*768 resolution in winXP Pro. The site looks good, just a few design comments:

1) The banner portion looks very empty, beside the &quot;Basak's Butt Sacks&quot; (which has got to the be the funniest name for a business aside from BJ), anywho you need to fill that space up with something, perhpas a banner??

2) Just looked at the &quot;contact&quot; page noticed that the validation only looks to see if the email field is not blank, so if someone entered just 'iam' without the @ or the . the form still gets sent. You might also want to do a validation on the name as well, how else would you know who to respond back to??

[sub]I have this little thing, Advanced Delusionary Schizophrenia with Involuntary Narcissistic Rage. It's no big deal really...[/sub]
 
Thanks GUJUmOdeL. Those are two things I was actually working on. I was thinking of putting some pictures of the products in that big empty space. I'm not too happy with that header being so large but I don't want the logo to be any smaller. Since you mentioned a banner I feel better about putting some product pictures up there. Maybe the pics can be chosen randomly from the products in the store.

As for the contact page, that's still being worked on. I've been looking (though not too hard) for some sort of validation script. Any ideas where I can get a good one?

Also, before anyone notices this, the store's not complete yet, for example you can't check out. I also made a change in my script that screwed something up so I'm trying to figure out what I did. If you try to add an item to your cart it doesn't work :-( I should have that fixed soon though.

Another quirk is that in the store, the items (at least in IE) don't have any vertical space between them. I think this is because I floated the image so it sticks out below the div it's in. I'll have to play around with it to see what I can do about that.

Thanks again to everyone for your comments!

Kevin
A+, Network+, MCP
 
philote, yeah I pics of some products on that space might &quot;fill up&quot; space, and at the same time you don't have to resize the logo. I was thinking something like a slideshow of products, this way you can display more then a select few. Kinda like an &quot;sneak preview&quot; of what else you have.

About the validation script, this will help validate for the email:
Code:
<html>
<head>
<title>Full E-Mail Validation</title>

<script>
function emailtest() {
//created a var 'ketan' to call document.formName once, after this initial instance call, every time you want to call document.formName just call ketan.  (ex: ketan.fieldName.value == &quot;&quot; is same as document.formName.fieldName.value == &quot;&quot;)
var ketan = document.testing
//this IF will check to make sure the email field has an @ and an . in it (hence the makeup of an email address) and it will make sure the field is not blank, before submitting.
   if (ketan.email.value.indexOf(&quot;@&quot;) == -1 || ketan.email.value == &quot;&quot; || ketan.email.value.lastIndexOf(&quot;.&quot;) == -1) {
      alert(&quot;Please include a proper email address. Ex: name@ISP.com&quot;);
	  ketan.email.focus();
      return false;
   }
}
</script>
</head>

<body>
<form name=&quot;testing&quot; action=&quot;&quot; method=&quot;post&quot; onSubmit=&quot;return emailtest()&quot;>
    <input type=&quot;text&quot; name=&quot;email&quot; /><br><br>
    <input type=&quot;Submit&quot; name=&quot;Submit&quot; value=&quot;Submit&quot; />
</form>
<p>Enter something into the field that is not conform to an email, try to submit, see what happens.</p>
</body>
</html>



[sub]I have this little thing, Advanced Delusionary Schizophrenia with Involuntary Narcissistic Rage. It's no big deal really...[/sub]
 
I like the look of the menu. However, the space at the top is too large and wasted (as already mentioned). I recommend getting away from the two-tone color that divides the page. Move the menu to the top and have your nice logo beside the menu - not above it. Then the logo could actually run into the contents of the page and you could save a ton of space.

Have you considered no bg color at all? Notice that most major successful sites are predominately white....

Programming today is a race between software engineers striving to build better and bigger idiot-proof programs, and the Universe trying to produce bigger and better idiots. So far, the Universe is winning. - Rick Cook (No, I'm not Rick)

fart.gif
 
Status
Not open for further replies.

Part and Inventory Search

Sponsor

Back
Top