another delete confirm q 2

[mthompo]

have an onclick event for my image

onclick= "if (ew_confirm('Are You Sure?')) {this.form.action='custaddcourtcars.asp';this.form.submit();this.form.a.value='D'};"

function ew_confirm(msg)
{
	var agree=confirm(msg);
	if (agree)
		return true ;
	else {
		return false ;
	}
}

can someone tell me why this submits the form even if a user clicks Cancel
when someone clicks OK i want it to submit the form
with D as the value for the form element
but if they click cancel i want it to do nothing

 

[cLFlaVA]

is it an image input tag?



*cLFlaVA
----------------------------
[tt]"quote goes here"[/tt]
[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[mthompo]

yes

<input name="Action2" type="image" id="Action2" src="images/tbot12_02.gif" width="67" height="50" border="0" onclick= "if (ew_confirm('Are You Sure?')) {this.form.action='custaddcourtcars.asp';this.form.submit();this.form.a.value='D'};">

 

[cLFlaVA]

that's why.

i would create a function to make it a little neater:

function doSubmit(i) {
    i.form.action = 'custaddcourtcars.asp';
    i.form.elements['a'].value = 'D';
}

onclick="if(confirm('blah')) { doSubmit(); } else { return false; }"

*cLFlaVA
----------------------------
[tt]"quote goes here"[/tt]
[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[mthompo]

doesnt seem to change value of a
is my hidden element wrong?

<input type="hidden" name="a" value="A">

 

[cLFlaVA]

no. is it inside your form tags?



*cLFlaVA
----------------------------
[tt]"quote goes here"[/tt]
[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[mthompo]

yep - defo inside form tags
goin home now, will check back 2mora

 

[ggriffit]

if you change your HIDDEN attribute to a TEXT field do you see the value change ?

Greg Griffiths
Livelink Certified Developer & ECM Global Star Champion 2005

http://www.greggriffiths.org/livelink/

 

[mthompo]

definately doesnt change the value

 

[tsuji]

><input name="Action2" type="image" id="Action2" src="images/tbot12_02.gif" width="67" height="50" border="0" onclick= "if (ew_confirm('Are You Sure?')) {this.form.action='custaddcourtcars.asp';this.form.submit();this.form.a.value='D'};">

[1] You have to realize that input type="image" is a submit button. Hence, you don't have to script in the .submit() in the onclick.
[2] Even if you then script in the .submit() there, your line to change the input named a field is after the .submit(), the changing value is thereby not effective.

This would, I think, do.

[tt]<input name="Action2" type="image" id="Action2" src="images/tbot12_02.gif" width="67" height="50" border="0" onclick= "if (ew_confirm('Are You Sure?')) {this.form.action='custaddcourtcars.asp';this.form.a.value='D';return true} else {return false};">[/tt]

 

[mthompo]

that works great - thanks tsuji

 

[cLFlaVA]

glad i could be so helpful as well. changing [tt]doSubmit();[/tt] to [tt]doSubmit(this);[/tt] in my example worked perfectly as well, and is slightly more portable. that's ok though.



*cLFlaVA
----------------------------
[tt]"quote goes here"[/tt]
[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[mthompo]

am new to jscript so didnt 'spot the prob'
thanks for trying to make me learn

 

[BillyRayPreachersSon]

yep - defo inside form tags
goin home now, will check back 2mora

As these are intelligent forums for professional people, cuold you try and avoid using "leet speak" in future? It really isn't very professional.

Dan

Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[mthompo]

my apologies - was trying to get out of the office!