add/edit records in mySQL db using PHP

cbhead · Jan 8, 2004

Hi,
I'm building a php page to add/edit records in a mySQL db.
I'm having a problem with the following code.
I have written in capital letters on the line above where the error occurs and the error message returned by the browser.
The mySQL db is a single table with ID auto increment(primary key).
I would appreciate any ideas.
Thanks.

<html>
<head>
<title>Outline Vacancies input test</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body bgcolor="#FFFFCC" text="#000000">

<?php
if($submit)
{
require( 'connect_jobs1.php' );

$sql = "INSERT INTO allvacs (ID, company, job, location, salary, hours) VALUES ('','$company','$job','$location','salary','hours');";

$result = mysql_query($sql);

echo "Thank you! Information entered.\n";
}
else if($update)
{
require( 'connect_jobs1.php' );

$sql = "UPDATE allvacs SET ID='',company='$company',job='$job',location='$location',salary='$salary',hours='$hours',

salary='$salary' WHERE ID=$ID";

$result = mysql_query($sql);
echo "Thank you! Information updated.\n";
}
else if($ID)
{
require( 'connect_jobs1.php' );

$result = mysql_query("SELECT * FROM allvacs WHERE ID=$ID",$db);

$myrow = mysql_fetch_array($result);

?>

<form method="post" action="addedit.php">

<input type="hidden" name="id" value="<?php echo $myrow["id"]?>">

**ERROR ON THIS LINE Parse error: parse error, unexpected ':', expecting ',' or ';' in /extra0/

http://WWW/gvacs/addedit.php

on line 47**

company:<input type="Text" name="company" value="<?php echo

job:<input type="Text" name="job" value="<?php echo $myrow["job"]?>"><br>

location:<input type="Text" name="location" value="<?php echo $myrow["location"]?>"><br>

salary:<input type="Text" name="salary" value="<?php echo $myrow["salary"]?>"><br>

hours:<input type="Text" name="hours" value="<?php echo $myrow["hours"]?>"><br>

<input type="Submit" name="update" value="Update information"></form>
<?
}
else
{
?>
<form method="post" action="addedit.php">
company:<input type="Text" name="company"><br>
job:<input type="Text" name="job"><br>
location:<input type="Text" name="location"><br>
salary:<input type="Text" name="salary"><br>
hours:<input type="Text" name="hours"><br>
<input type="Submit" name="submit" value="Enter information"></form>
<?
}
?>
</html>

shaddow · Jan 8, 2004

You should take out the ID='' from the query, you dont need to update and read only field(autoincrement)

Code:

$sql = &quot;UPDATE allvacs SET company='$company',job='$job',location='$location',salary='$salary',hours='$hours',
salary='$salary' WHERE ID=$ID&quot;;

________
George, M

cbhead · Jan 8, 2004

I have removed ID from the query so it looks like this:-

$sql = "UPDATE allvacs SET company='$company',job='$job',location='$location',salary='$salary',hours='$hours',

salary='$salary' WHERE ID=$ID";

but I'm still getting the same error message.

Any ideas?

hos2 · Jan 8, 2004

yep you forgot the ; behind the echo (and also on the other form fields)

Code:

input type=&quot;hidden&quot; name=&quot;id&quot; value=&quot;<?php echo $myrow&quot;id&quot;;?>&quot;>

cbhead · Jan 8, 2004

Still no joy!
This is the code I have now after adding semi colons. I've also tried it without the square brackets but am still getting the same error back.

<form method="post" action="addedit.php">

<input type="hidden" name="ID" value="<?php echo $myrow["ID"];?>">

company:<input type="Text" name="company" value="<?php echo

job:<input type="Text" name="job" value="<?php echo $myrow["job"];?>"><br>

location:<input type="Text" name="location" value="<?php echo $myrow["location"];?>"><br>

salary:<input type="Text" name="salary" value="<?php echo $myrow["salary"];?>"><br>

hours:<input type="Text" name="hours" value="<?php echo $myrow["hours"];?>"><br>

<input type="Submit" name="update" value="Update information"></form>
<?
}
else
{
?>

shaddow · Jan 8, 2004

You can use this code i've made for simplify work but also i see something that could be wrong.

Code:

the line <?php echo $myrow&quot;job&quot;;?> should be
<?php echo $myrow[&quot;job&quot;];?> i think you forgot brackets around the field name.

http://www.pubfiction.ro/rs.zip

________
George, M

hos2 · Jan 8, 2004

and is it also not a concatation?
<input type="hidden" name="ID" value="<?php echo $myrow."ID";?>">

see perhaps also

http://nl3.php.net/manual/en/function.echo.php

hos2 · Jan 8, 2004

and yes the logic of using concatation as a namefield instead of arrays is strange ??

shaddow · Jan 8, 2004

PHP is a strange language...

You never stop learning things.

________
George, M

hos2 · Jan 8, 2004

and does it work ??

shaddow · Jan 8, 2004

I dont knw, i'm waiting also the response.
To lazy to verify that

________
George, M

Vragabond · Jan 8, 2004

Hmm, I don't think either of this is the problem here. You do not need to add a semi-colon at the end of the echo line if right after that you close the php block (?>), so that wouldn't be a problem. I think the gone brackets are just TGML's work, since he didn't put the [code][/code] around. What baffles me is this:

Code:

company:<input type=&quot;Text&quot; name=&quot;company&quot; value=&quot;<?php echo

job:<input type=&quot;Text&quot; name=&quot;job&quot; value=&quot;<?php echo $myrow[&quot;job&quot;];?>&quot;><br>

If this is all there is to it then you have this kind of php command:

echo job:<input type="Text"...

which would made php choke for sure. Is there something that got lost in the copying or is this line really incomplete?

cbhead · Jan 13, 2004

Sorry about my absence for the last few days.

I appreciate all the efforts to help me with this but I'm still unable to make it work.

I admit that I am not an expert on PHP, I used the folowing tutorial to get most of the code that I am using.

http://www.id.unizh.ch/publications/pdf/php-mysql.pdf

It may help to look at this to find out what I am doing wrong.

It is topic 6, editing data. It is meant to create a page called addedit.php that I can use to add, delete and ammend records.

The part that is not working should display a record from the db and then allow the user to edit it.

Also, it may be useful to know that the code I copied and pasted in earlier threads did not show square brackets around the field names that I included.

Hope this helps.

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

add/edit records in mySQL db using PHP

cbhead

Technical User

shaddow

Programmer

cbhead

Technical User

hos2

Programmer

cbhead

Technical User

shaddow

Programmer

hos2

Programmer

hos2

Programmer

shaddow

Programmer

hos2

Programmer

shaddow

Programmer

Vragabond

Programmer

cbhead

Technical User

Similar threads

Part and Inventory Search

Sponsor