A Simple question

[milams]

I have a href link where I want to open a pop up window when someone clicks on the link. Ive tried it this way, but the parent page would change and say [NULL].

<div class="abs">
<a class="emaillink" href="javascript:window.open('email_subscript.htm','','width=300,height=300,top=50,left=40')">Join our Email List!</a>
</div>

So I went ahead and changed it to this below and it seems to work. My question is, is that the right way to write this?

<div class="abs">
<a class="emaillink" href="#" onclick="javascript:window.open('email_subscript.htm','','width=300,height=300,top=50,left=40')">Join our Email List!</a>
</div>

 

[cLFlaVA]

speaking for myself only, that is the preferred method. additionally, i'd add a [tt]return false;[/tt] to the onclick event and remove the [tt]javascript:[/tt] reference:

<a class="emaillink" href="#" onclick="window.open('email_subscript.htm','','width=300,height=300,top=50,left=40'); return false;">Join our Email List!</a>

the [tt]return false[/tt] ensures that the page won't scroll to the top (which the # specifies). another, even more stealth way is this:

<a class="emaillink" href="[red]email_subscript.htm[/red]" onclick="window.open('email_subscript.htm','','width=300,height=300,top=50,left=40'); return false;">Join our Email List!</a>

which will open the email_subscript.htm in a new page if the user has javascript enabled, but will still open the url in the SAME WINDOW if they have javascript disabled.

this, in my opinion, is the best way, aside from using the target attribute.



*cLFlaVA
----------------------------
[tt]( <P> <B>)¹³ * (<P> <.</B>)[/tt]

[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[milams]

That works a lot better. Thanks cLFlaVA.

 

[jmille34]

I like this one in my projects:

<a class="emaillink" href="email_subscript.htm" onclick="window.open('email_subscript.htm','','width=300,height=300,top=50,left=40'); return false;">Join our Email List!</a>

Except I change it slightly:

<a class="emaillink" href="email_subscript.htm" onclick="window.open(this.href,'','width=300,height=300,top=50,left=40'); return false;">Join our Email List!</a>

 

[cLFlaVA]

nice jmille, that's actually what i meant to post, but became absent-minded.

became? who am i kidding...



*cLFlaVA
----------------------------
[tt]( <P> <B>)¹³ * (<P> <.</B>)[/tt]

[URL unfurl="true"]http://www.coryarthus.com/[/url]