A nightmare of quoted quotes 1

[columb]

Hi all

I've developped a script for checking that quotes are balanced in other scripts. It looks like

#!/bin/ksh

[[ $# -ne 1 ]] && { echo invalid param count; exit 1; }

[[ -r $1 ]] || { echo Unable to read $1; exit 1; }

awk -v CH=\' '{
 occ=0;
 while (y=index($0,CH))
 {
  occ++;
  y++;
  $0=substr($0,y);
 }
 if (occ%2)
  print "line " NR ": " occ " occurrences of " CH
}' $1

awk -v CH=\" '{
 occ=0;
 while (y=index($0,CH))
 {
  occ++;
  y++;
  $0=substr($0,y);
 }
 if (occ%2)
  print "line " NR ": " occ " occurrences of " CH
}' $1

awk -v CH=\` '{
 occ=0;
 while (y=index($0,CH))
 {
  occ++;
  y++;
  $0=substr($0,y);
 }
 if (occ%2)
  print "line " NR ": " occ " occurrences of " CH
}' $1

So far so good but, if ever a script screamed for a loop it's this one. I get as far as

#!/bin/ksh

[[ $# -ne 1 ]] && { echo invalid param count; exit 1; }

[[ -r $1 ]] || { echo Unable to read $1; exit 1; }

for quote in \' \" \`
do
  awk -v CH=

and then it all goes wrong.

Any ideas/pointers would be more than welcome.


On the internet no one knows you're a dog

Columb Healy

 

[columb]

Ignore my post - it was so simple I overlooked it.

The answer was

#!/bin/ksh

[[ $# -ne 1 ]] && { echo invalid param count; exit 1; }

[[ -r $1 ]] || { echo Unable to read $1; exit 1; }

for quote in \' \" \`
do
  awk -v CH=$quote '{
   occ=0;
   while (y=index($0,CH))
   {
    occ++;
    y++;
    $0=substr($0,y);
   }
   if (occ%2)
    print "line " NR ": " occ " occurrences of " CH
  }' $1
done

On the internet no one knows you're a dog

Columb Healy

 

[KenCunningham]

Thanks for posting your solution Columb.

I want to be good, is that not enough?

 

[columb]

Thanks for the star Ken, in case anyone finds it useful here's a version with comments

#!/bin/ksh

#Script for checking that quotes in other scripts are balanced
#Script to be tested is passed as $1

#Check we have one, and only one passed script
[[ $# -ne 1 ]] && { echo invalid param count; exit 1; }

#Check we can read the script passed as $1
[[ -r $1 ]] || { echo Unable to read $1; exit 1; }

# For each type of quote print lies which have uneven numbers of that type of quote.
for quote in \' \" \`
do
  awk -v CH=$quote '{
   occ=0;
   #While CH found in $0
   while (y=index($0,CH))
   {
    #Increment count of CH and reset $0 to next char
    occ++;
    y++;
    $0=substr($0,y);
   }
   # If count of CH is not divisible by 2
   if (occ%2)
    #print line number and count of CH
    print "line " NR ": " occ " occurrences of " CH
  }' $1
done

On the internet no one knows you're a dog

Columb Healy