2 Parts - Replacing listA with listB and grouping results 1

[Waraq]

PART1:
I have a script that is taking values from a form and then emailing the results. At present, the results that are getting mailed are tagged by the form field ID (i.e. ada) but I would like it to be converted to the full name (i.e. Adabas). I use a sort to put the fields in a consistent order, but without doing a continual
foreach $key (sort(keys(%FORM))) {
if ($key eq 'naturaladabase') {
print MAIL "Natural Adabase (MF) \t\t\t";
} elsif ($key eq 'asset') {
print MAIL "Asset Management (BK) \t\t\t";
} ...
}

how would I convert to the correct items?

PART2:
How could I group the items in different areas (hence the MF and BK in parenthesis)?

Thanks.

 

[yauncin]

You can make a hash whose keys are the form ids and the values are the actual name.

Unfortunately, I'm really not sure what you are asking... maybe an example would help.

 

[Waraq]

The field names on the form are abbreviations (i.e. field1, field2, field3,...) and when I send the email to the person, I want to change the abbreviations to the full field name (i.e. Field Name 1, Field Name 2, Field Name 3,...) so basically I want to replace the fieldname abbreviation list with the fieldname fullname list.

Hope this lends a little insight.

Thanks.

 

[tsdragon]

Why not create a hash with the key as the fieldname abbreviation, and the value as the full fieldname. Then you would use it the same way you use the form hash. For example:

%FullNames = (
   "naturaladabase" => "Natural Adabase (MF)",
   "asset" => "Asset Management (BK)",
...
);
...
print MAIL $FullNames{$key},"\t\t\t";
...

That would solve the field names problem. Tracy Dryden
tracy@bydisn.com

http://www.bydisn.com

Meddle not in the affairs of dragons,
For you are crunchy, and good with mustard.

 

[yauncin]

Isn't that what I said, without the example? Of course at the time I wasn't really sure if that was what he wanted. And examples are always good.

 

[Waraq]

Thanks a lot, that worked, but how would I do step 2 now?

 

[tsdragon]

That's a little trickier. Any idea how many groups you're going to need, or is that going to change over time? If you have a relatively small number of groups that isn't likely to change much, you might be able to use a hash for each group containing the key/value pairs. Tracy Dryden
tracy@bydisn.com

http://www.bydisn.com

Meddle not in the affairs of dragons,
For you are crunchy, and good with mustard.

 

[Waraq]

Tracy,

The pairs are designated by the value in the () at the end of the name if that makes it any easier and it is a set number.

 

[tsdragon]

I think what I'd do is create a hash containing the groups as keys, with their values references to anonymous hashes containing the key/value pairs for that group. It sounds complicated, but it's not terribly so:

%FullNames = (
   "naturaladabase" => "Natural Adabase (MF)",
   "asset" => "Asset Management (BK)",
...
);
...
foreach $key (keys(%FORM)) {
   $fullname = $FullNames{$key};
   # match the group and extract it
   ($group) = $fullname =~ /.*?\((.*?)\).*?/;
   # if a group hash doesn't exist, create it
   if ( !defined $Groups{$group} ) {
      # create a ref to an anonymous hash
      $Groups{$group} = { };
   }
   # add the key/value to the Group hash
   $Groups{$group}{$key} = $FORM{$key};
} # end foreach
...
# Now print the keys and values, sorted by group
foreach $group (sort(keys($Groups))) {
   print "Group $group\n";
   foreach $key (sort(keys($Groups{$group}))) {
      print MAIL $FullNames{$key}."\t\t\t";
   }
}
...

Does that make sense? I haven't tested it.
Tracy Dryden
tracy@bydisn.com

http://www.bydisn.com

Meddle not in the affairs of dragons,
For you are crunchy, and good with mustard.

 

[Waraq]

Tracey,

It makes sense, thanks but I am getting 2 errors when I do a compile:

Type of arg 1 to keys must be hash (not scalar deref) at academy_surveypost.cgi line 146, near "$Groups)"

Type of arg 1 to keys must be hash (not hash elem) at academy_surveypost.cgi line 148, near "})"

I think they are at the print:
# Now print the keys and values, sorted by group
foreach $group (sort(keys($Groups))) {
print "Group $group\n";
foreach $key (sort(keys($Groups{$group}))) {
print MAIL $FullNames{$key}."\t\t\t";
}
}

any ideas?

 

[Waraq]

Tracey,

I got the errors fixed, I was confusing hashes and scalars.... but now the problem that I am having is that I can't print the values in the categories...only the categories are printing.

 

[tsdragon]

OOPS. Told you I hadn't tested the code. That first line you got the error on should be:

foreach $group (sort(keys(%Groups))) {

I think the other error line should be something like:

    foreach $key (sort(keys(%{$Groups{$group}}))) {

but I'm not real sure about that last one.

I also notice that I'm not printing the group name to the MAIL file like I am the other print line. And I didn't see anywhere in your original posting where you actually used the VALUES from the form, just the keys. If you want to get the values too, you'll need to use:

# this is the value for a given key in a group
$Groups{$group}{$key}

Tracy Dryden
tracy@bydisn.com

http://www.bydisn.com

Meddle not in the affairs of dragons,
For you are crunchy, and good with mustard.