Not satisfying a while loop (probably very obvious)

[HughbertD]

Hi all,

I execute this while loop, and it never stops.

$rownumber is definitely 3.

my ($rownumber) = $execute->numrows();



# FETCHROW ARRAY


my ($i)=0;

while (my (@results) = $execute->fetchrow() && $i<=$rownumber)
{

      	$sheet1->write(0, $i, $results[0], $format);
     	$sheet1->write(1, $i, $results[1]);
        print $i;
        $i++;

}

 

[HughbertD]

Okay I just figured this out literally the second I hit submit.

I was trying to hard with my conditions. The first condition, (@results) controls the amount of output. The second condition confuses it I think.

 

[KevinADC]

Well, look at the logic:

$i <= 3

probably $i never is greater than 3, so the while loop never ends. You should not need that anyway.

while (my @results = $execute->fetchrow())
{

          $sheet1->write(0, $i, $results[0], $format);
         $sheet1->write(1, $i, $results[1]);

}

That should do it. As soon as fetchrow() no longer returns a value to @results the while loop ends.

------------------------------------------
- Kevin, perl coder unexceptional!