having a little problem with require()

[TheAtomic]

<?php
if($page == ""){$page = "main";} ;
if($name == ""){$name = "blank";} ;

if($gallery == "true"){require("pics/".$name."_index.php");}
else {require("$page.php");}

?>

If i set gallery to 'true' and name to 'hols' (which the page its linking to exists) it just shows a blank page...

index.php?gallery=true&name=hols

Im sure it something to do with

require("pics/".$name."_index.php");

but Im not sure what...

 

[jemminger]

this
require("pics/".$name."_index.php");

will evaluate to this
pics/hols_index.php

are you sure this file exists relative to where you're calling it from? i.e. {calling_dir}/pics/hols_index.php



-jeff

http://www.jeffemminger.com

try { succeed(); } catch(E) { tryAgain(); } finally { rtfm(); }
i like your sleeves...they're real big

 

[TheAtomic]

Yep most definatly exists.

it being called from:

http://www.example.com/test/index.php?gallery=true&name=hols

http://www.example.com/test/pics/hols_index.php

 

[TheAtomic]

and without the ; in the first URL.

 

[Chacalinc]

do you have register global ON? turn it off! and use $_GET

for:

index.php?gallery=true&name=hols
==>

if($_GET['name'] == ""){$name = "blank";} ;

if($$_GET['gallery'] == "true"){require("pics/".$name."_index.php");}

Chacal, Inc.

 

[TheAtomic]

narrowed the problem right down now.

{require("pics/".$name."_index.php");}

If i change it to:

{require("".$name."_index.php");}

and create hols_index.php in the same folder, it gets the file correctly, the problem is getting it to include it from a sub directory...

 

[jemminger]

as an aside, you can replace
{require("".$name."_index.php");}

with
{require("$name_index.php");}

and it will work the same

-jeff

http://www.jeffemminger.com

try { succeed(); } catch(E) { tryAgain(); } finally { rtfm(); }
i like your sleeves...they're real big

 

[sleipnir214]

as an aside, you can replace
{require("".$name."_index.php");}

with
{require("$name_index.php");}

and it will work the same

That doesn't work on my system, and I'm not suprised, as "$name_index.php" is ambiguous. That ambiguity is going to trip up the parser and will make the script less readable.

Want the best answers? Ask the best questions!

TANSTAAFL!!

 

[TheAtomic]

How odd...

{require("./pics/".$name."_index.php");}

Works fine

 

[jemminger]

true - the leading underscore does it. this should work though:

{require("${name}_index.php");}




-jeff

http://www.jeffemminger.com

try { succeed(); } catch(E) { tryAgain(); } finally { rtfm(); }
i like your sleeves...they're real big

 

[sleipnir214]

That's still less readable. What's wrong with:

{require($name . '_index.php');}

You have an explicit concatentation of a variable's value and a string constant. No weird attempts to abuse variable variables, no implicit concatenation.

Want the best answers? Ask the best questions!

TANSTAAFL!!

 

[jemminger]

personal preference. it's easier to write that way than it is to explicitly concatenate. i find it just as legible.

-jeff

http://www.jeffemminger.com

try { succeed(); } catch(E) { tryAgain(); } finally { rtfm(); }
i like your sleeves...they're real big